Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all repositories (regardless of code style) #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Jun 8, 2017

This PR fixes this list of issues I found in the script:

  • Doesn't work license headers and code documentation, which are written like so:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
    	longValueName:	"This string is long",
    	foo:	"foo",
    	bar:	"bar",
    	getBaz	= function getBaz()
    	{
    		return bar;
    	}
    }
    This should render as:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
            longValueName: "This string is long",
            foo:           "foo",
            bar:           "bar",
            getBaz         = function getBaz()
            {
                    return bar;
            }
    }
    But because of the does line start with a space check in index.js#41, this doesn't happen, because the second line of this file turns elastic tabstops off.
  • Fixes broken tab size:
    This is done by using the ch unit instead of the em unit
  • Fixes broken tab alignment:
    This is done by ensuring that the wrapAllTabs() function doesn't try to wrap a tab multiple times.
  • Moves the custom CSS into github.user.css to be loaded by Stylus or Stylish.
    This makes it an optional feature rather than something that users are forced to use.

@ExE-Boss ExE-Boss mentioned this pull request Jun 8, 2017
@ExE-Boss ExE-Boss force-pushed the fix/generic-repo-support branch 2 times, most recently from 8fd34bc to 8a57969 Compare June 8, 2017 20:55
@hax
Copy link
Owner

hax commented Jul 6, 2017

Thank you for the PR. It would be better if you could separate it to multiple PRs for each feature/bugfix.

@ExE-Boss
Copy link
Author

ExE-Boss commented Sep 4, 2017

@hax I have split off this PR into #4, #5 and #6. #4 and #6 are ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants