Skip to content

Commit

Permalink
Fix the bug that retrieved tweets may not be rendered.
Browse files Browse the repository at this point in the history
Thanks to irie who reported the problem.

* twittering-mode.el: Fix the bug that retrieved tweets may not be
rendered. This bug is caused by the previous commit. Thanks to
irie who reported the problem.
(twittering-add-statuses-to-timeline-data): call
`twittering-render-timeline' correctly.
  • Loading branch information
cvmat committed Jun 16, 2013
1 parent f802da3 commit a65362d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 6 deletions.
10 changes: 9 additions & 1 deletion ChangeLog
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
2013-06-16 Tadashi MATSUO <tad@mymail.twin.jp>

* twittering-mode.el: Fix the bug that retrieved tweets may not be
rendered. This bug is caused by the previous commit. Thanks to
irie who reported the problem.
(twittering-add-statuses-to-timeline-data): call
`twittering-render-timeline' correctly.

2013-06-15 Tadashi MATSUO <tad@mymail.twin.jp>

* twittering-mode.el: Fix the bug that a hook may be invoked twice
for the same timeline.
for the same timeline. Thanks to irie who discoverd the problem.
(twittering-add-statuses-to-timeline-data): do not invoke a hook
twice for the timeline spec given as `spec'.

Expand Down
9 changes: 4 additions & 5 deletions twittering-mode.el
Original file line number Diff line number Diff line change
Expand Up @@ -4774,10 +4774,7 @@ string and the number of new statuses for the timeline."
(let ((other-spec (twittering-get-timeline-spec-for-buffer buffer))
(other-spec-string
(twittering-get-timeline-spec-string-for-buffer buffer)))
(when (and
(twittering-timeline-spec-depending-on-p other-spec spec)
;; The hook has been alreadly invoked for `spec'.
(not (equal spec other-spec)))
(when (twittering-timeline-spec-depending-on-p other-spec spec)
(let* ((twittering-new-tweets-spec other-spec)
(twittering-new-tweets-statuses
(twittering-generate-composite-timeline
Expand All @@ -4788,7 +4785,9 @@ string and the number of new statuses for the timeline."
(twittering-render-timeline
buffer twittering-new-tweets-statuses t)))
(when rendered-tweets
(run-hooks 'twittering-new-tweets-hook)
(when (not (equal spec other-spec))
;; The hook has been alreadly invoked for `spec'.
(run-hooks 'twittering-new-tweets-hook))
`(,other-spec-string ,(length rendered-tweets)))))))
(twittering-get-buffer-list))))))

Expand Down

0 comments on commit a65362d

Please sign in to comment.