-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
103. Binary Tree Zigzag Level Order Traversal #35
base: main
Are you sure you want to change the base?
Conversation
return [] | ||
nodes = [root] | ||
level = 0 | ||
ans = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ans について、プログラム中で何を表しているかを表す単語にした方が良いと思います。自分なら order とつけますが、もう少し良い名前があるかもしれません。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。命名サボってしまいました。
node = nodes[i] | ||
values.append(node.val) | ||
first, second = access_orders[level % 2] | ||
first_node = getattr(node, first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リフレクション的な機能は極力使用しないほうが良いと思います。理由は、コンパイル時の静的な解析でエラーを特定することが難しくなる場合があるためです。
nodes_ordered = [] | ||
zigzag_order_nodes_by_level(root, 1) | ||
# dequeのlistになっているのでlistに変換する | ||
ans = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return [list(nodes) for nodes in nodes_ordered]
と掛けなくはないのですが、少し指しすぎかもしれません。
実際の現場においては、単純な内包表記であれば、読みやすさを考慮したうえで使用しても大丈夫だと思います。
https://leetcode.com/problems/binary-tree-zigzag-level-order-traversal/