Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-364] PodDisruptionBudget support #287

Merged
merged 9 commits into from
Aug 1, 2022
Merged

[CN-364] PodDisruptionBudget support #287

merged 9 commits into from
Aug 1, 2022

Conversation

semihbkgr
Copy link
Member

@semihbkgr semihbkgr commented Jul 25, 2022 •
edited
Loading

TODOs:

  • add comment for new fields in values.yaml
  • update table in README.md
  • apply same changes for hazelcast-enterprise

fixes #272

@semihbkgr semihbkgr mentioned this pull request Jul 26, 2022
Closed
@semihbkgr semihbkgr changed the title create pod disruption budget template [CN-364] create pod disruption budget template Jul 26, 2022
@mtyazici
Copy link
Contributor

@semihbkgr, can you also increase the Chart version by looking at the current version in the master branch. Right now the updated one is the same as the master one.

@semihbkgr semihbkgr changed the title [CN-364] create pod disruption budget template [CN-364] PodDisruptionBudget support Jul 27, 2022
mtyazici
mtyazici approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@mtyazici mtyazici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with both of the option we talked offline. Maybe if you use the current options, we should comment about using Helm version greater than 3.7 for using PodDistruptionBudget.

@hasancelik hasancelik merged commit 63b3cea into hazelcast:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasancelik hasancelik hasancelik approved these changes

@mtyazici mtyazici mtyazici approved these changes

Assignees
No one assigned
Labels
safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability To Create a PodDisruptionBudget
3 participants
@semihbkgr @mtyazici @hasancelik