Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hotRestart parameter to persistence [CN-681] #333

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Rename hotRestart parameter to persistence [CN-681] #333

merged 7 commits into from
Jan 11, 2023

Conversation

SeriyBg
Copy link
Contributor

@SeriyBg SeriyBg commented Jan 5, 2023

No description provided.

@SeriyBg SeriyBg requested review from a team, kutluhanmetin and cagric0 and removed request for a team January 5, 2023 14:02
@hasancelik
Copy link
Collaborator

hasancelik commented Jan 10, 2023 •
edited
Loading

fixes #280

cagric0
cagric0 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@cagric0 cagric0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question, should we mention that we break backward compatibility in somewhere?

@SeriyBg SeriyBg merged commit c8dd9b2 into master Jan 11, 2023
@SeriyBg SeriyBg deleted the CN-681-persistence branch January 11, 2023 10:46
@hasancelik hasancelik mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kutluhanmetin kutluhanmetin kutluhanmetin approved these changes

@cagric0 cagric0 cagric0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SeriyBg @hasancelik @kutluhanmetin @cagric0