Add putAllWithMetadata into client protocol [HZ-2583] #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frant-hartm
commented
Jul 27, 2023
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Jul 27, 2023
Client protocol PR: hazelcast/hazelcast-client-protocol#468
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Jul 27, 2023
Client protocol PR: hazelcast/hazelcast-client-protocol#468
6 tasks
srknzl
previously approved these changes
Jul 31, 2023
frant-hartm
added a commit
to hazelcast/hazelcast
that referenced
this pull request
Aug 1, 2023
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Aug 4, 2023
The PR adds new codec/message task and internal API in ClientMapProxy, reuses existing MergeOperation. Using the same operation as during split brain/WAN replication makes it easy to explain the behaviour. Client protocol PR: hazelcast/hazelcast-client-protocol#468 We exceptionally add a new API to support the data migration tool on 5.3.z as the target cluster.
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Aug 4, 2023
The PR adds new codec/message task and internal API in ClientMapProxy, reuses existing MergeOperation. Using the same operation as during split brain/WAN replication makes it easy to explain the behaviour. Client protocol PR: hazelcast/hazelcast-client-protocol#468 We exceptionally add a new API to support the data migration tool on 5.3.z as the target cluster.
3 tasks
ihsandemir
reviewed
Aug 4, 2023
protocol-definitions/Map.yaml
Outdated
| since: 2.7 | ||
| doc: | | ||
| Put a batch of entries with metadata into an IMap. This is a client side version of WAN entry replication. |
There was a problem hiding this comment.
may be you can add some more details as in the doc of putAll message (includes some details about partitions etc.).
srknzl
previously approved these changes
Aug 8, 2023
srknzl
approved these changes
Aug 9, 2023
ihsandemir
approved these changes
Aug 9, 2023
srknzl
added a commit
to hazelcast/hazelcast
that referenced
this pull request
Aug 9, 2023
The PR adds a new codec/message task and internal API in ClientMapProxy and reuses existing MergeOperation. Using the same operation as during split-brain/WAN replication makes it easy to explain the behavior. Client protocol PR: hazelcast/hazelcast-client-protocol#468 We exceptionally add a new API in patch to support the data migration tool on 5.3.z as the target cluster. Breaking changes (list specific methods/types/messages): - New API addition in a patch version . The new API is internal though Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com>
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Sep 8, 2023
The PR adds new codec/message task and internal API in ClientMapProxy, reuses existing MergeOperation. Using the same operation as during split brain/WAN replication makes it easy to explain the behaviour. Client protocol PR: hazelcast/hazelcast-client-protocol#468
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Sep 8, 2023
The PR adds a new codec/message task and internal API in ClientMapProxy and reuses existing MergeOperation. Using the same operation as during split-brain/WAN replication makes it easy to explain the behavior. Client protocol PR: hazelcast/hazelcast-client-protocol#468 Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com>
3 tasks
frant-hartm
added a commit
to hazelcast/hazelcast
that referenced
this pull request
Sep 11, 2023
The PR adds new codec/message task and internal API in ClientMapProxy, reuses existing MergeOperation. Using the same operation as during split brain/WAN replication makes it easy to explain the behaviour. Client protocol PR: hazelcast/hazelcast-client-protocol#468 This is `master` version of #25144 Also updates the client protocol after merging hazelcast/hazelcast-client-protocol#466. These client protocol changes were merged in #23509, but with a wrong since version. Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.