Assigns Viridian as the default coordinator for cloud invocations [API-1556] #145
Conversation
✅ Deploy Preview for eclectic-sawine-19fcf1 canceled.
|
run.go
Outdated
| return err | ||
| } | ||
|
|
||
| func setDefaultCoordinator(logger *log.Logger) { |
There was a problem hiding this comment.
Why does this function get a logger as parameter?
There was a problem hiding this comment.
It logs if it can not assign the default URL. Do you suggest an alternative flow?
There was a problem hiding this comment.
Maybe you can just return the error. Since if the coordinator URL cannot be set we shouldn't continue to run the command anyway.
There was a problem hiding this comment.
I think for many usecases this may be non-critical. For those cases just logging makes sense for me. Wdyt?
There was a problem hiding this comment.
I think it's a serious problem if the user intends to connect to Viridan but it can't since the coordinator URL was not set correctly. What we can do is to call setDefaultCoordinator only when we know the user wants to connect to the cloud.
There was a problem hiding this comment.
Good idea, updated as discussed e51609e
|
@utku-caglayan Could you also change: to: |
No description provided.