Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements on .NET Client #56

Closed
burakcelebi opened this issue Mar 24, 2016 · 5 comments · Fixed by #353
Closed

Logging improvements on .NET Client #56

burakcelebi opened this issue Mar 24, 2016 · 5 comments · Fixed by #353
Labels
Priority: High High Priority. Type: Enhancement Code enhancement.
Milestone

Comments

@burakcelebi
Copy link
Member

This is what we do on the server. We need to provide the same level of version information on the clients.

INFO: [10.0.0.2]:5701 [dev] [3.6-EA2] Hazelcast 3.6-EA2 (20151125 - 8af85c5) starting at Address[10.0.0.2]:5701

  • 3.6-EA2 is the version.
  • Hazelcast 3.6-EA2 is the full name
  • 20151125 is the release date
  • 8af85c5 is the GitHub Id.

See https://github.com/hazelcast/hazelcast/releases. You will see it corresponds to EA2

@burakcelebi burakcelebi added the Type: Enhancement Code enhancement. label Mar 24, 2016
@cangencer
Copy link
Contributor

Java PR: hazelcast/hazelcast#7521

@cangencer cangencer added this to the 3.7 milestone May 24, 2016
@cangencer
Copy link
Contributor

Logging should also include the Hazelcast client instance name.

@cangencer cangencer changed the title Version Info on .NET Client Logging improvements on .NET Client May 25, 2016
@asimarslan asimarslan modified the milestone: 3.7 Oct 26, 2016
@asimarslan asimarslan added this to the 3.9.1 milestone Oct 16, 2017
@asimarslan asimarslan modified the milestones: 3.9.1, Backlog Nov 17, 2017
@burakcelebi burakcelebi added the Priority: High High Priority. label Dec 12, 2018
@burakcelebi burakcelebi modified the milestones: Backlog, 3.11 Jan 25, 2019
@zpqrtbnk
Copy link
Contributor

zpqrtbnk commented Dec 8, 2020

version 4.0 currently reports

Authenticated client "hz.client_1" (8eb5391) with cluster "dev" member d333ab7 running version 4.0 at 127.0.0.1:5701 via 127.0.0.1:37480.

when a client connection authenticates on a member - where "4.0" is the version we receive from the server, so I assume we'd received "4.0-WHATEVER" if that was what the server was running. OTOH the server does not send the release date nor the release GitHub SHA for us to report.

We may want to report the client's version too - looking into it.

@zpqrtbnk
Copy link
Contributor

zpqrtbnk commented Dec 8, 2020

Notes: reviewing other clients, we have

C++:

08/12/2020 20:19:09.802 INFO: [0x11427edc0] hz.client_1[little-endian-cluster] [4.0-SNAPSHOT] 
[../hazelcast/src/hazelcast/client/spi.cpp:379] (Mon Nov 30 16:35:50 2020 +0300:503c66fdf0) 
LifecycleService::LifecycleEvent Client (9f0cab3a-ea09-4c03-b964-97fd3e9bc632) is STARTING

Java:

INFO: [localhost]:5701 [dev] [4.1] Received auth from Connection[id=1, 
/127.0.0.1:5701->/127.0.0.1:55769, qualifier=null, endpoint=[127.0.0.1]:55769, alive=true,
connectionType=CPP, planeIndex=-1], successfully authenticated, clientUuid: 
3ff2c70c-6f1b-49a6-b07f-f5e63313a323, client version: 4.0-SNAPSHOT

@zpqrtbnk
Copy link
Contributor

zpqrtbnk commented Dec 8, 2020

Proposing the following for C#:

info: Hazelcast.Clustering.ClusterConnections[0]
      Auth. client 'hz.client_1' (e3e1906) version 4.0.0-preview.3+97c7c0 connection 4c49ce3 
      127.0.0.1:1855 -> 127.0.0.1:5701 cluster 'dev' version 4.0 member d333ab7.

@zpqrtbnk zpqrtbnk modified the milestones: Backlog, 4.0 Dec 9, 2020
zpqrtbnk added a commit that referenced this issue Dec 10, 2020
fix #56) (#353)

* Improve logging when auth. to cluster, align with Java and C++

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High High Priority. Type: Enhancement Code enhancement.
Projects
None yet
4 participants