[v1.1.1] Handle Lost Invocations [API-992] #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuce
changed the title
yuce
changed the title
sancar
reviewed
Nov 4, 2021
| @@ -47,6 +50,42 @@ func TestListenersAfterClientDisconnected(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestNotReceivedInvocation(t *testing.T) { | |||
There was a problem hiding this comment.
If you want to avoid accessing internals and do a test from public API, you can send a long running task to the remote. An EntryProcessor for example which just sleeps. And then close the member.
There was a problem hiding this comment.
I wonder whether there is an entry processor you mentioned exists in the test jar. I'll try to find that.
sancar
reviewed
Nov 4, 2021
|
Can we rename GroupID to ConnectionID ? We don't have a concept like group in other clients. |
sancar
reviewed
Nov 4, 2021
yuce
changed the title
sancar
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupLostevent which contains the connection ID (group ID). and the reason of disconnection. Invocation service subscribes to that event, and closes matching invocations. TheConnectionClosedevent is not used for this purpose in order to avoid depending oninternal/clusterfor theinternal/invocationpackage which would result in cyclic dependency.