WriteKafkaP should support mapping to ProducerRecord directly #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangencer
force-pushed
the
write-kafka
branch
from
1e9fcf3
to
e919407
Compare
mtopolnik
reviewed
Nov 9, 2017
| import static java.util.stream.IntStream.range; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| @Category(QuickTest.class) | ||
| @RunWith(HazelcastSerialClassRunner.class) | ||
| public class WriteKafkaPTest extends KafkaTestSupport { |
There was a problem hiding this comment.
Shouldn't this now be called KafkaSinkTest and be moved to the appropriate package?
viliam-durina
approved these changes
Nov 9, 2017
cangencer
force-pushed
the
write-kafka
branch
from
e919407
to
d470cf5
Compare
mtopolnik
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.