Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility issues for compact #1275

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Apr 25, 2022

Fixes https://github.com/alisengul53/client-compatibility-suites/runs/6137120286?check_suite_focus=true

I will test the back compat tests with this PR in my fork.

@srknzl srknzl added this to the 5.1.0 milestone Apr 25, 2022
@srknzl srknzl changed the title Fix backward compatiblity issues for compact Fix backward compatibility issues for compact Apr 25, 2022
@srknzl srknzl force-pushed the compact-backward-compat-fixes branch from ea75111 to 709fc8a Compare April 25, 2022 14:06
utku-caglayan
utku-caglayan previously approved these changes Apr 25, 2022
Copy link

@utku-caglayan utku-caglayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1275 (8459c94) into master (e1123a5) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   92.16%   91.78%   -0.39%     
==========================================
  Files         463      463              
  Lines       16347    16347              
  Branches     1329     1329              
==========================================
- Hits        15067    15004      -63     
- Misses        892      949      +57     
- Partials      388      394       +6     
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) ⬇️
src/network/ConnectionManager.ts 75.35% <0.00%> (-9.63%) ⬇️
src/util/Util.ts 87.26% <0.00%> (-1.28%) ⬇️
src/config/ConfigBuilder.ts 89.67% <0.00%> (-1.01%) ⬇️
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) ⬇️
src/invocation/InvocationService.ts 94.50% <0.00%> (-0.79%) ⬇️
src/core/HazelcastError.ts 77.27% <0.00%> (-0.76%) ⬇️
src/protocol/ErrorFactory.ts 64.66% <0.00%> (-0.76%) ⬇️
src/proxy/NearCachedMapProxy.ts 94.32% <0.00%> (+1.41%) ⬆️
src/nearcache/NearCache.ts 93.79% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1123a5...8459c94. Read the comment docs.

@srknzl srknzl merged commit 14a6154 into hazelcast:master Apr 25, 2022
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
* Fix backward compatibility issues

* Fix leftover old usages of shouldReadAndWrite method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants