-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backward compatibility issues for compact #1275
Fix backward compatibility issues for compact #1275
Conversation
ea75111
to
709fc8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
- Coverage 92.16% 91.78% -0.39%
==========================================
Files 463 463
Lines 16347 16347
Branches 1329 1329
==========================================
- Hits 15067 15004 -63
- Misses 892 949 +57
- Partials 388 394 +6
Continue to review full report at Codecov.
|
* Fix backward compatibility issues * Fix leftover old usages of shouldReadAndWrite method
Fixes https://github.com/alisengul53/client-compatibility-suites/runs/6137120286?check_suite_focus=true
I will test the back compat tests with this PR in my fork.