Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging does not work if written in lowercase(hazelcast.logging.level) [API-1740] #1432

Merged
merged 764 commits into from Dec 19, 2022
Merged
Changes from 1 commit
Commits
Show all changes
764 commits
Select commit Hold shift + click to select a range
7d707db
Add config checks (#959)
srknzl Jul 6, 2021
58b99a7
Update dependencies (#971)
srknzl Jul 12, 2021
004d3fe
API-602 Update links (#966)
srknzl Jul 13, 2021
5ca5e31
Add version check for flaky test (#972)
srknzl Jul 14, 2021
aa0a915
API-574 API-581 SQL 5.0 (#963)
srknzl Jul 27, 2021
0f428dc
API-579 SQL 5 docs & samples (#974)
srknzl Jul 28, 2021
4bd0a3c
API-631 Add portable methods for DECIMAL and DATE/TIME (#967)
srknzl Jul 29, 2021
1b4a388
Update dependencies (#987)
srknzl Jul 30, 2021
1396db0
Remove broken anchors (#993)
srknzl Jul 30, 2021
35ac7a3
Update dependencies (#998)
srknzl Aug 2, 2021
b9229cb
Add version check to dateTimeUtil (#999)
srknzl Aug 2, 2021
ea7a8fb
Add getConnectionForSql and use it (#988)
srknzl Aug 3, 2021
f9ae3e0
Fail fast on failover wrong key and add tests (#977)
srknzl Aug 3, 2021
fed2386
API-543 Add bigint serializer (#975)
srknzl Aug 4, 2021
b359b88
API-579 Add code samples for decimal and date/time classes usage (#973)
srknzl Aug 5, 2021
1911b61
API-657 GH actions (#978)
srknzl Aug 5, 2021
32382e9
Update ttl values to fix flaky tests (#1002)
srknzl Aug 6, 2021
d5cc70c
Update dependencies (#1013)
srknzl Aug 9, 2021
18e3b36
API-664 Add code sample checker (#989)
srknzl Aug 9, 2021
6286c85
Make dependabot monthly (#1014)
srknzl Aug 9, 2021
ea313be
Delete Object.setPrototypeOf calls in HazelcastErrors (#1005)
srknzl Aug 10, 2021
55bf59d
Fix tests and code samples (#1020)
srknzl Aug 16, 2021
4965cf5
Codecov report upload step is added (#1019)
alisengul53 Aug 16, 2021
e9b3d45
Return same promise for multiple shutdown calls (#1003)
srknzl Aug 17, 2021
0c7bbf8
API-668 Document and Validate Properties (#1001)
srknzl Aug 17, 2021
5f75236
API-676 Implement distinct aggregator (#1007)
srknzl Aug 18, 2021
a53d292
Fix DistributedObjectsTest and HazelcastClientTest failures due to in…
srknzl Aug 25, 2021
d5decdc
Rename json to json-flat (#1025)
srknzl Aug 27, 2021
b9dcbc8
Fix sql tests and code samples (#1034)
srknzl Sep 1, 2021
9f7effe
Update dependencies (#1035)
srknzl Sep 1, 2021
266ab50
Add paging predicate sample (#1000)
srknzl Sep 2, 2021
f8a36a5
API-673 HeartbeatfromServer flaky test fix (#1006)
srknzl Sep 2, 2021
18c9a28
Make codecov informational (#1026)
srknzl Sep 2, 2021
d104ca5
Make codecov patch informational (#1039)
srknzl Sep 8, 2021
acbd748
Eslint config changes (#1036)
srknzl Sep 8, 2021
372bdc7
Add markdown linter API-869 (#1040)
srknzl Sep 8, 2021
6a9f8cb
Update unisocket mode docs (#1042)
srknzl Sep 13, 2021
ca48de7
Add client version check (#1052)
srknzl Sep 17, 2021
6454ce7
ClientReconnectTest flaky test fix (#1053)
srknzl Sep 20, 2021
2f41262
Make sql execute return promise api-877 (#1046)
srknzl Sep 24, 2021
6f9aa3d
Provide suggestions for `HazelcastSqlException` (#1055)
srknzl Sep 27, 2021
ecf6971
Deserialize rows lazily (#1056)
srknzl Sep 27, 2021
acba775
Update api documentation for SQL 5 api-877 (#1057)
srknzl Sep 27, 2021
8185d33
Update SQL documentation & small typo fix api-877 (#1060)
srknzl Sep 29, 2021
c9bc2c8
Test fixes (#1061)
srknzl Sep 29, 2021
74f93b7
Documentation & apidoc refactor 5.0 (#1062)
srknzl Sep 29, 2021
92d0a79
5.0.0
devOpsHazelcast Oct 1, 2021
df44c29
Update dependencies (#1078)
srknzl Oct 1, 2021
49bb234
Add check for existence of lib folder and increase version to 5.1.0 (…
srknzl Oct 6, 2021
3ae0381
API-684 Enable parallel tests to decrease ci time (#1017)
srknzl Oct 6, 2021
97310ad
Update clean script (#1085)
srknzl Oct 7, 2021
785965b
Fix ListenersOnReconnectTest serial test (#1084)
srknzl Oct 7, 2021
ec40e8a
API-868 Disable asserts (#1027)
srknzl Oct 8, 2021
263e2d0
Add `bytesSend` and `bytesReceived` tcp metrics api-927 (#1087)
srknzl Oct 12, 2021
56ad035
Add unit to tcp metrics (#1088)
srknzl Oct 12, 2021
108d2b8
Downgrade typedoc (#1086)
srknzl Oct 18, 2021
320c9de
Fix api docs links (#1093)
srknzl Oct 18, 2021
46caa89
Add entry validation to setAll and putAll (#1079)
srknzl Oct 18, 2021
f92caa9
Change coverage config api-928 (#1082)
srknzl Oct 19, 2021
03f089d
Add nightly runner api-919 (#1094)
srknzl Oct 20, 2021
d1e191e
Fix address util test for loopback of ipv6 (#1095)
srknzl Oct 22, 2021
f534980
Fix execute test for back compat (#1101)
srknzl Oct 22, 2021
81aa782
Close connection on socket `end` as well as `error` (#1098)
srknzl Oct 25, 2021
4bbb691
Add 4.0.2 version check to MigratedDataTest (#1102)
srknzl Oct 25, 2021
1f9b020
Fix custom serializer doc (#1103)
srknzl Oct 26, 2021
468747c
Increase timeouts in MapProxyTest (#1104)
srknzl Oct 26, 2021
849c45b
Refactor api doc and add validation errors (#1069)
srknzl Oct 26, 2021
ae53c25
Add readme sample and point to it from README (#1110)
srknzl Oct 26, 2021
a4e4729
Refactor and Cleanup (#1063)
srknzl Oct 26, 2021
34d57fc
Validate methods in config api-915 (#1080)
srknzl Oct 26, 2021
9700864
Improve ClusterService's getMembers (#1111)
srknzl Oct 27, 2021
5cd7e62
Update dependencies (#1123)
srknzl Nov 1, 2021
7371979
Add new logo (#1124)
srknzl Nov 2, 2021
3bf7be9
Small refactors (#1125)
srknzl Nov 3, 2021
4805801
Refactor custom and global serializer stuff (#1113)
srknzl Nov 5, 2021
9977e0f
Refactor listener service api-873 (#1044)
srknzl Nov 5, 2021
16317d7
Update server (#1131)
srknzl Nov 11, 2021
2bff4fa
Fix flaky MapLockTest (#1132)
srknzl Nov 12, 2021
61603d6
Update and rename jira_trigger.yml to jira.yml
degerhz Nov 24, 2021
f1c71dd
Update jira.yml
degerhz Nov 24, 2021
8a2c10f
Fix SqlExeceuteTest for the older clients (#1144)
mdumandag Dec 6, 2021
f5a90e6
[API-1018] Introduce security configuration (#1146)
mdumandag Dec 14, 2021
d6b0657
Fix typo in the token authentication documentation (#1149)
mdumandag Dec 16, 2021
3f01c57
Improve security config validation (#1152)
srknzl Dec 29, 2021
114510d
Update dependencies (#1155)
srknzl Dec 30, 2021
5a62e27
Delete linting from nigthly runner that run on master (#1158)
srknzl Jan 6, 2022
fe5b3ae
Refactor some components and documentation (#1130)
srknzl Jan 6, 2022
f111c54
ClientClusterService apply events only with version larger than local…
srknzl Jan 6, 2022
eb61921
Fix CPSessionManagerTest (#1164)
srknzl Jan 6, 2022
1cc430f
Fix SecurityTest for back compatibility tests and fix skip logic (#1168)
srknzl Jan 11, 2022
a132fa2
Change server version calculation to allow more flexible versions (#1…
srknzl Jan 12, 2022
28651b5
Make simple credentials back compatible (#1170)
srknzl Jan 12, 2022
37ec7cf
Bump hazelcast in /code_samples/paging_predicate_sample/main (#1175)
dependabot[bot] Jan 24, 2022
9ab6329
Fix NearCachedMapTest (#1177)
srknzl Jan 25, 2022
b74d026
Fix nearcachedmaptest 2nd attempt (#1179)
srknzl Jan 27, 2022
affa6cb
Update dependencies (#1166)
srknzl Feb 2, 2022
212b15c
Bump sinon from 12.0.1 to 13.0.0 (#1185)
dependabot[bot] Feb 2, 2022
90a28d3
Add caused by for more verbose errors (#1178)
srknzl Feb 9, 2022
a80dc87
Deprecate statistics props and add metrics props API-1181 (#1136)
srknzl Feb 11, 2022
87eb720
Fix LocalDateTime.fromDate (#1180)
srknzl Feb 15, 2022
7a36500
API-1106 SQL JSON support (#1162)
srknzl Feb 21, 2022
5e79650
Isolate failing near cache test (#1196)
srknzl Feb 25, 2022
658f245
Update docker tag in readme (#1201)
srknzl Mar 2, 2022
4d04262
Update dependencies (#1213)
srknzl Mar 2, 2022
d98e397
Update a broken link (#1214)
srknzl Mar 2, 2022
17f5fcb
Fix ListenersOnReconnect test's one fail scenario API-1196 (#1202)
srknzl Mar 3, 2022
71977a0
Fix out of date serializers API-1115 (#1197)
srknzl Mar 4, 2022
1136430
[master] Fix bugs in listeneronreconnecttest API-1196 (#1217)
srknzl Mar 4, 2022
8906edc
Fix listeneronreconnecttest backcompat bug (#1220)
srknzl Mar 7, 2022
18d195c
Fix flaky HazelcastClientTest (#1236)
srknzl Mar 16, 2022
ed83825
Bump hazelcast in /code_samples/paging_predicate_sample/main (#1243)
dependabot[bot] Mar 18, 2022
283100c
Fix flaky MigratedDataTest (#1241)
srknzl Mar 18, 2022
b49d5f3
Fix flaky lost invalidation test (#1231)
srknzl Mar 18, 2022
66beeb0
Fix TranslateAddressProviderTest API-1111 (#1251)
srknzl Mar 21, 2022
a9fed23
Increase timeouts in MapProxyTest API-1200 (#1255)
srknzl Mar 21, 2022
03614f1
Decrease job count (#1253)
srknzl Mar 21, 2022
8ec46c0
Convert MapLockTest to async/await API-1264 (#1252)
srknzl Mar 22, 2022
634a8fc
Update SQL JSON code sample for rerunability (#1257)
srknzl Mar 22, 2022
d289081
Add boundary unit tests to datetime classes API-1238 (#1221)
srknzl Mar 23, 2022
7322659
Make retry count 100 (#1259)
srknzl Mar 24, 2022
6c26900
Update copyright year to 2022 (#1271)
srknzl Apr 5, 2022
c461d33
Update dependencies (#1274)
srknzl Apr 14, 2022
98bbccf
API-553 Compact serialization and Generic Records (#1172)
srknzl Apr 22, 2022
3201668
Fix backward compatibility issues for compact (#1275)
srknzl Apr 25, 2022
c8cc609
Compact & Generic records code samples API-1160 (#1195)
srknzl Apr 26, 2022
15d0a2d
Compact & generic records reference manual API-1157 (#1194)
srknzl Apr 26, 2022
046da5c
Add test for proxy APIs if they throw serialization errors other than…
srknzl Apr 27, 2022
6e454f9
Add field numbers explicitly (#1276)
srknzl May 9, 2022
1a9d39a
Refactor assertTrueEventually to make output better (#1264)
srknzl May 9, 2022
58e9483
rc log file extension is changed (#1295)
alisengul53 May 16, 2022
880f1f8
Update the SSL certificate used in tests (#1297)
mdumandag May 30, 2022
499998f
Add undefined to EntryListener interface (#1294)
srknzl May 30, 2022
59a16ae
New coverage runner (#1293)
alisengul53 May 31, 2022
0fc3db1
[TRIVIAL] Use test network 2 ip as unreachable host... (#1296)
srknzl May 31, 2022
3fc2e71
Update dependencies (#1310)
srknzl Jun 2, 2022
69fde16
Enable strict in user code tsconfig to catch type definition files er…
srknzl Jun 18, 2022
831ad03
Run nightlies in Node 10 and 18 which are the oldest supported and ne…
srknzl Jun 18, 2022
3a1e282
Fix typos, missing information and not working code samples [API-1067…
fatihozer0 Aug 16, 2022
0b3b197
Add skip checks for 5.2-BETA compatiblity tests (#1356)
srknzl Aug 19, 2022
6512926
Port nested compact serialization sample [API-1332] (#1350)
fatihozer0 Sep 1, 2022
2fd1d7f
Add map.RemoveAll() method [API-15] (#1364)
fatihozer0 Sep 14, 2022
48094bf
Add an example code for `map.removeAll` method [API-15] (#1369)
fatihozer0 Sep 20, 2022
25c4452
Nested compact field's serializer can be None if it is not registered…
mehmettokgoz Sep 28, 2022
c93fd5e
Fix leak in ReliableTopicListenerRunner.next (#1377)
srknzl Sep 30, 2022
24a8ebe
Fix broken complete documentation link (#1390)
fatihozer0 Oct 10, 2022
ac088f2
Add 5.2 version checks for the tests that are for map.removeAll (#1391)
srknzl Oct 11, 2022
54a906b
Add skipped check before asserting in CompactPublicAPIsTest.afterEach…
srknzl Oct 11, 2022
9d7aa7b
Make ReadResultSet iterable [API-1315]
harunalpak Oct 13, 2022
fd9a9f4
Make ReadResultSet iterable [API-1315]
harunalpak Oct 13, 2022
b62a77d
Make ReadResultSet iterable [API-1315]
harunalpak Oct 13, 2022
5ecb3b1
Make ReadResultSet iterable [API-1315]
harunalpak Oct 13, 2022
fab84a2
merge code
harunalpak Oct 13, 2022
0a8da09
merge code
harunalpak Oct 13, 2022
77fce4a
Merge branch 'hazelcast:master' into master
harunalpak Oct 13, 2022
3a26c8f
Merge branch 'hazelcast:master' into master
harunalpak Oct 13, 2022
7a9cb25
Changes made according to comments on PR.[API-1315]
harunalpak Oct 14, 2022
1e908b1
Changes made according to comments on PR.[API-1315]
harunalpak Oct 14, 2022
d95a69c
Fix invalid error message [API-1490] (#1349)
fatihozer0 Oct 14, 2022
1f21026
Make ReadResultSet iterable [API-1315] (#1399)
harunalpak Oct 14, 2022
1487261
Merge remote-tracking branch 'upstream/master'
harunalpak Oct 24, 2022
a1c7c38
Merge remote-tracking branch 'upstream/master'
harunalpak Oct 24, 2022
de54c93
Change doTryNextCluster logic to make it the same. [API-1354] (#1403)
harunalpak Oct 25, 2022
2949b27
Remove createDistributedObjectsOnCluster from client start (#1404)
fatihozer0 Oct 27, 2022
83646dc
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 2, 2022
fea3900
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 2, 2022
2daa58a
Apply Compact Serialization Updates for Hz v5.2.0 I [API-1637] (#1409)
harunalpak Nov 17, 2022
6f8a0a6
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 17, 2022
654f854
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 17, 2022
8f17e50
Add filter argument to ringbuffer readMany() method and a test for it…
fatihozer0 Nov 20, 2022
f8ae3f0
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 21, 2022
5adc9a9
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 21, 2022
d14aea6
Change default cloud coordinator URL to point to Viridian[API-1680] (…
harunalpak Nov 25, 2022
7bc7b35
Improve documentation for primitive-nullable primitive field interope…
harunalpak Nov 25, 2022
6a6fa3b
Change default cloud coordinator URL to point to Viridian[API-1680] (…
harunalpak Nov 25, 2022
439bad5
Change default cloud coordinator URL to point to Viridian[API-1680] (…
harunalpak Nov 25, 2022
8b31d1d
Improve documentation for primitive-nullable primitive field interope…
harunalpak Nov 25, 2022
2b5028e
Improve documentation for primitive-nullable primitive field interope…
harunalpak Nov 25, 2022
09d46dd
Send client state to cluster in re-connections[API-1644] (#1415)
harunalpak Nov 28, 2022
a5fabcb
Merge remote-tracking branch 'upstream/master'
Nov 29, 2022
0570d5c
Merge remote-tracking branch 'upstream/master'
harunalpak Nov 29, 2022
937712d
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
3b80e2f
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
218d7e8
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
b0d56b5
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
d07c070
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
b1b900a
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 2, 2022
60d11dc
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 2, 2022
c91211b
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 2, 2022
b87b1d1
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 2, 2022
468371e
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
83fc5b3
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
19e9897
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
31f1191
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
aa77bed
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
d94db93
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 5, 2022
0aeb648
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 5, 2022
815953e
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 5, 2022
d583488
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 5, 2022
b9b3466
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
739b427
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
0f89cc5
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
f299cf8
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
01b6d2d
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
6b989f6
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
e1df29b
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
707e1e2
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
29d8f41
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
07f39d3
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
53000b5
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
f75acdc
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
6bbe14a
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
641f053
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
81135a1
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
9bde5cd
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 6, 2022
e4ea6d1
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 6, 2022
87de7a2
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 6, 2022
d99d296
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 6, 2022
ec9a2c4
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
315451b
Check the member UUIDs that the schema is replicated in the client sc…
harunalpak Dec 2, 2022
ff49a29
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
ef7a3b9
Do not invoke urgent invocations that contains serialized data immedi…
harunalpak Dec 2, 2022
8daca6d
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
4a6bcae
Update dependencies & update documentation (#1428)
srknzl Dec 5, 2022
4da9d51
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
2f22dcd
Change logic around closing connections and writers API-1283 (#1417)
srknzl Dec 5, 2022
a760d53
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
4ca0cb3
Revert "Change logic around closing connections and writers API-1283 …
srknzl Dec 5, 2022
3b4ec3a
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 7, 2022
e970a94
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 7, 2022
79abb09
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 7, 2022
f16f29f
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 7, 2022
2fadb68
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 8, 2022
aaf74b3
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 8, 2022
cecc8b2
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 8, 2022
192b7be
Logging does not work if written in lowercase(hazelcast.logging.level…
harunalpak Dec 8, 2022
275ade9
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 9, 2022
8c4ceaa
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 12, 2022
dcb66b4
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 13, 2022
ab0d337
Fix nightly runner workflow
harunalpak Dec 13, 2022
bd7e891
Fixed related to PR review
harunalpak Dec 13, 2022
099c53a
For windows GITHUB_WORKSPACE not working. Replaced $GITHUB_WORKSPACE …
harunalpak Dec 13, 2022
d33cdbd
Updating coverage_runner.yml
harunalpak Dec 13, 2022
b5248dd
documentation update
harunalpak Dec 13, 2022
cf72c26
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 13, 2022
8100729
Merge branch 'master' of https://github.com/harunalpak/hazelcast-node…
harunalpak Dec 14, 2022
a399ee6
Add comment for property value in sample
harunalpak Dec 14, 2022
0f4a528
Merge remote-tracking branch 'upstream/master'
harunalpak Dec 14, 2022
0210e66
Merge branch 'master' into API-1740
harunalpak Dec 14, 2022
91e4dc1
null check added for enumFromString function
harunalpak Dec 14, 2022
5e92ece
Fixing test fail
harunalpak Dec 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util/Util.ts
Expand Up @@ -69,7 +69,7 @@ export function shuffleArray<T>(array: T[]): void {

/** @internal */
export function enumFromString<T>(enumType: any, value: string): T {
return enumType[value.toUpperCase()];
return enumType[value ? value.toUpperCase() : value];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not need this. Just ensure where we use enumFromString, value is a string indeed.

}

/** @internal */
Expand Down