Logging does not work if written in lowercase(hazelcast.logging.level) [API-1740] #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now if a config key is wrong the client fails fast
Changes: * Add datetime classes back, add default serializers, change year in codec to be int * Update tests and serialization * Update binary compat test * Add date/time to default serializers test * Adjust tests according to back compat * Rename sql service getter to getSql * Adjust timezone string * Add jet tests * Add constructors for datetime wrappers
* Add code sample checker * Update code samples to add client.shutdown
* Add distinct aggregator and tests * Update documentation
…ternal proxies (hazelcast#1023) * Fix DistributedObjectsTest failure due to internal proxies * Fix HazelcastClientTest
* Test adjustments around jet enabled config for backward compatbility tests * Fix datatypetest.js * Move createMapping to TestUtil and use it in all sql integration tests * Fix code samples
|
|
srknzl
requested changes
Dec 8, 2022
|
Can you update the documentation as well? https://github.com/srknzl/hazelcast-nodejs-client/blob/192b7be3059916f33e1c31c10612bdd54364498e/DOCUMENTATION.md#L654 |
…=> ${{ github.workspace }}
srknzl
reviewed
Dec 13, 2022
srknzl
previously approved these changes
Dec 14, 2022
srknzl
reviewed
Dec 14, 2022
src/util/Util.ts
Outdated
| @@ -69,7 +69,7 @@ export function shuffleArray<T>(array: T[]): void { | |||
|
|
|||
| /** @internal */ | |||
| export function enumFromString<T>(enumType: any, value: string): T { | |||
| return enumType[value.toUpperCase()]; | |||
| return enumType[value ? value.toUpperCase() : value]; | |||
There was a problem hiding this comment.
You should not need this. Just ensure where we use enumFromString, value is a string indeed.
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
+ Coverage 93.34% 93.37% +0.02%
==========================================
Files 466 466
Lines 16616 16623 +7
Branches 1348 1351 +3
==========================================
+ Hits 15511 15522 +11
+ Misses 803 798 -5
- Partials 302 303 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srknzl
approved these changes
Dec 15, 2022
srknzl
pushed a commit
to fatihozer0/hazelcast-nodejs-client
that referenced
this pull request
Mar 24, 2023
…) [API-1740] (hazelcast#1432) * Logging does not work if written in lowercase(hazelcast.logging.level) [API-1740]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple change, I only add toUpperCase().
I am not sure we need extra test for this. I added a sample test for logging.