[CN-539] Add MultiMap CR #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagric0
requested review from
hasancelik and
dzeromski-hazelcast
and removed request for
a team
mtyazici
reviewed
Sep 23, 2022
| } | ||
| } | ||
|
|
||
| h := &hazelcastv1alpha1.Hazelcast{} |
There was a problem hiding this comment.
Can we make this a function? AFAIR, we are using the same code block in the map reconciler.
hasancelik
requested changes
Sep 30, 2022
There was a problem hiding this comment.
Can we add multimap removal logic into the Hazelcast CR finalizer as we did for Map CR before?
dzeromski-hazelcast
approved these changes
Oct 4, 2022
hasancelik
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CR created and auto generated files are added.
Phonehome data and sample yaml are added.
addMultiMapConfig codec is added
Controller, and integration-e2e tests are implemented.