Implement boomerang backups #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
boomerang-backups
branch
from
70f5a25
to
f7caa65
Compare
Boomerang backups implementation, documentation, tests and required configuration options, namely, `backup_ack_to_client_enabled`, `clean_resources_period`, `operation_backup_timeout`, `fail_on_indeterminate_operation_state` are added. Also, another test dependency is added to make mocking the failure scenarios easier. Added dependency, `mock`, comes with the standard library on Python3.3+, but due to support for Python2.7, it is added.
mdumandag
force-pushed
the
boomerang-backups
branch
from
f7caa65
to
7039b00
Compare
sancar
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boomerang backups implementation, documentation, tests, required configuration options, namely,
backup_ack_to_client_enabled,operation_backup_timeoutandfail_on_indeterminate_operation_stateare added.Also, another test dependency is added to make mocking the failure scenarios easier.
Added dependency,
mock, comes with the standard library on Python3.3+, but due tosupport for Python2.7, it is added.
depends on #221