Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make printed report file link clickable #1933

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

ahmetmircik
Copy link
Member

Terminal link will be clickable.

@ahmetmircik ahmetmircik added this to the 0.13 milestone Apr 12, 2021
@ahmetmircik ahmetmircik requested a review from kwart April 12, 2021 08:18
@ahmetmircik
Copy link
Member Author

run-lab-run

Comment on lines 1151 to 1152
print("HTML report generated at: "+"\u001b]8;;file://"
+ file_name + "\u001b\\" + file_name + "\u001b]8;;\u001b\\")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my Ubuntu Mate, this way helps neither in the MATE Terminal nor in the Terminator. :( Nevertheless, if we keep the scheme prefix in the path, it will work OOTB.

Suggested change
print("HTML report generated at: "+"\u001b]8;;file://"
+ file_name + "\u001b\\" + file_name + "\u001b]8;;\u001b\\")
file_url = "file://" + file_name
print(f"HTML report generated at: \u001b]8;;{file_url}\u001b\\{file_url}\u001b]8;;\u001b\\")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@ahmetmircik ahmetmircik requested a review from kwart April 14, 2021 06:13
@ahmetmircik ahmetmircik merged commit fe91167 into hazelcast:master Apr 14, 2021
@ahmetmircik ahmetmircik deleted the 0.13/enhancement/click branch April 14, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants