Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #7531 from ahmetmircik/fix/3.7/interceptorAddRemov…
…eLeak Fixes possible leak caused by concurrent add/remove of IMap interceptors
- Loading branch information
Showing
7 changed files
with
315 additions
and
47 deletions.
There are no files selected for viewing
124 changes: 124 additions & 0 deletions
124
hazelcast/src/main/java/com/hazelcast/map/impl/InterceptorRegistry.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| * Copyright (c) 2008-2016, Hazelcast, Inc. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.hazelcast.map.impl; | ||
|
|
||
| import com.hazelcast.map.MapInterceptor; | ||
| import com.hazelcast.spi.impl.operationexecutor.classic.PartitionOperationThread; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static java.util.Collections.emptyList; | ||
| import static java.util.Collections.emptyMap; | ||
| import static java.util.Collections.unmodifiableList; | ||
| import static java.util.Collections.unmodifiableMap; | ||
|
|
||
| /** | ||
| * Registry for all {@link MapInterceptor} of an {@code IMap} | ||
| * | ||
| * Interceptors are read mostly and this registry keeps all registered interceptor in an array to easily iterate on them. | ||
| * Other than that, synchronized blocks are used to prevent leaks when concurrently registering/de-registering interceptors. | ||
| * Keep in mind that all registration/de-registration operations are done in generic-operation-threads, in other words, | ||
| * synchronized methods are not used in partition-threads. | ||
| * | ||
| * This registry is created per map. | ||
| */ | ||
| public class InterceptorRegistry { | ||
|
|
||
| private volatile List<MapInterceptor> interceptors = emptyList(); | ||
| private volatile Map<String, MapInterceptor> id2InterceptorMap = emptyMap(); | ||
|
|
||
| /** | ||
| * Gives an instance of this registry according to generic-operation-thread count. | ||
| */ | ||
| public InterceptorRegistry() { | ||
| } | ||
|
|
||
| /** | ||
| * Returns all registered interceptors. | ||
| * | ||
| * This method is called by {@link PartitionOperationThread} | ||
| * | ||
| * @return all registered interceptors | ||
| * @see com.hazelcast.map.impl.recordstore.DefaultRecordStore#put | ||
| */ | ||
| public List<MapInterceptor> getInterceptors() { | ||
| return interceptors; | ||
| } | ||
|
|
||
| public Map<String, MapInterceptor> getId2InterceptorMap() { | ||
| return id2InterceptorMap; | ||
| } | ||
|
|
||
| /** | ||
| * Registers a {@link MapInterceptor} for the supplied `id`. | ||
| * If there is no registration associated with the `id`, registers interceptor, | ||
| * otherwise silently ignores registration. | ||
| * | ||
| * This method is called by {@link com.hazelcast.spi.impl.operationexecutor.classic.GenericOperationThread} | ||
| * when registering via {@link com.hazelcast.map.impl.operation.AddInterceptorOperation} | ||
| * | ||
| * @param id id of the interceptor | ||
| * @param interceptor supplied {@link MapInterceptor} | ||
| */ | ||
| public synchronized void register(String id, MapInterceptor interceptor) { | ||
| assert !(Thread.currentThread() instanceof PartitionOperationThread); | ||
|
|
||
| if (id2InterceptorMap.containsKey(id)) { | ||
| return; | ||
| } | ||
|
|
||
| Map<String, MapInterceptor> tmpMap = new HashMap<String, MapInterceptor>(id2InterceptorMap); | ||
| tmpMap.put(id, interceptor); | ||
|
|
||
| id2InterceptorMap = unmodifiableMap(tmpMap); | ||
|
|
||
| List<MapInterceptor> tmpInterceptors = new ArrayList<MapInterceptor>(interceptors); | ||
| tmpInterceptors.add(interceptor); | ||
|
|
||
| interceptors = unmodifiableList(tmpInterceptors); | ||
| } | ||
|
|
||
| /** | ||
| * De-registers {@link MapInterceptor} for the supplied `id`, if there is any. | ||
| * | ||
| * This method is called by {@link com.hazelcast.spi.impl.operationexecutor.classic.GenericOperationThread} | ||
| * when de-registering via {@link com.hazelcast.map.impl.operation.RemoveInterceptorOperation} | ||
| * | ||
| * @param id id of the interceptor | ||
| */ | ||
| public synchronized void deregister(String id) { | ||
| assert !(Thread.currentThread() instanceof PartitionOperationThread); | ||
|
|
||
| if (!id2InterceptorMap.containsKey(id)) { | ||
| return; | ||
| } | ||
|
|
||
| Map<String, MapInterceptor> tmpMap = new HashMap<String, MapInterceptor>(id2InterceptorMap); | ||
| MapInterceptor removedInterceptor = tmpMap.remove(id); | ||
|
|
||
| id2InterceptorMap = unmodifiableMap(tmpMap); | ||
|
|
||
| List<MapInterceptor> tmpInterceptors = new ArrayList<MapInterceptor>(interceptors); | ||
| tmpInterceptors.remove(removedInterceptor); | ||
|
|
||
| interceptors = unmodifiableList(tmpInterceptors); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.