Fixes possible leak caused by concurrent add/remove of IMap interceptors #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
force-pushed
the
fix/3.7/interceptorAddRemoveLeak
branch
4 times, most recently
from
181ec3c
to
4fb119c
Compare
ahmetmircik
changed the title
ahmetmircik
force-pushed
the
fix/3.7/interceptorAddRemoveLeak
branch
5 times, most recently
from
35c11be
to
fc29a6f
Compare
| Map<String, MapInterceptor> tmpMap = new HashMap<String, MapInterceptor>(id2InterceptorMap); | ||
| tmpMap.put(id, interceptor); | ||
|
|
||
| id2InterceptorMap = tmpMap; |
There was a problem hiding this comment.
Can you also wrap with Collections.unmodifiableMap()? Readers should not be able to modify.
id2InterceptorMap = Collections.unmodifiableMap(tmpMap);
ahmetmircik
force-pushed
the
fix/3.7/interceptorAddRemoveLeak
branch
from
fc29a6f
to
bdf6fd9
Compare
|
👍 |
|
Will you backport this? |
|
👍 |
gurbuzali
pushed a commit
that referenced
this pull request
Feb 17, 2016
…eLeak Fixes possible leak caused by concurrent add/remove of IMap interceptors
|
@mdogan backport is on the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the leak which is introduced in PR #3993
closes #7520