Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity - Using invalid iterator - SmartClientListenerService.deregisterListenerInternal(String) #11760

Closed
kwart opened this issue Nov 10, 2017 · 0 comments · Fixed by #11764
Assignees
Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Defect
Milestone

Comments

@kwart
Copy link
Member

kwart commented Nov 10, 2017

Calling the registrationMap.remove(subscriber); may break iterator in com.hazelcast.client.spi.impl.listener.SmartClientListenerService.deregisterListenerInternal(String)

        for (ClientEventRegistration registration : registrationMap.values()) {
            Connection subscriber = registration.getSubscriber();
//...
                registrationMap.remove(subscriber);
//...
        }

https://scan4.coverity.com/reports.htm#v32322/p13030/fileInstanceId=29225713&defectInstanceId=5757092&mergedDefectId=202221

@sancar sancar self-assigned this Nov 10, 2017
@sancar sancar added this to the 3.9.1 milestone Nov 10, 2017
sancar pushed a commit to sancar/hazelcast that referenced this issue Nov 10, 2017
sancar pushed a commit to sancar/hazelcast that referenced this issue Nov 10, 2017
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants