Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity - Missing call to superclass - LikePredicate and RegexPredicate #11768

Closed
kwart opened this issue Nov 10, 2017 · 0 comments · Fixed by #11932
Closed

Coverity - Missing call to superclass - LikePredicate and RegexPredicate #11768

kwart opened this issue Nov 10, 2017 · 0 comments · Fixed by #11932
Assignees
@taburet
Labels
Source: Internal PR or issue was opened by an employee Team: Core
Milestone
3.10

Comments

@kwart
Copy link
Member

kwart commented Nov 10, 2017 •
edited
Loading

Methods readObject(...) and writeObject(...) should call the method from superclass instead of handling the attributeName field themselves in classes LikePredicate and RegexPredicate.

Similarly also the one-param constructors in these classes could call one-param constructor from the superclass.

The correct handling is already present in other predicates (BetweenPredicate, EqualPredicate, GreaterLessPredicate, InPredicate).

https://scan4.coverity.com/reports.htm#v32322/p13030/fileInstanceId=29224151&defectInstanceId=5757072&mergedDefectId=202142
https://scan4.coverity.com/reports.htm#v32322/p13030/fileInstanceId=29224151&defectInstanceId=5757069&mergedDefectId=202218
https://scan4.coverity.com/reports.htm#v32322/p13030/fileInstanceId=29222183&defectInstanceId=5757064&mergedDefectId=202170
https://scan4.coverity.com/reports.htm#v32322/p13030/fileInstanceId=29222183&defectInstanceId=5757070&mergedDefectId=202219
@mmedenjak mmedenjak added this to the 3.10 milestone Nov 10, 2017
@taburet taburet self-assigned this Dec 7, 2017
@taburet taburet mentioned this issue Dec 7, 2017
Merged
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taburet taburet

Labels
Source: Internal PR or issue was opened by an employee Team: Core
Projects
None yet
Milestone
3.10
Development

Successfully merging a pull request may close this issue.

Fix missing calls to superclass in LikePredicate and RegexPredicate
3 participants
@kwart @taburet @mmedenjak