Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading disconnect exception on 3.11 JAVA_CLIENT #14244

Closed
neilstevenson opened this Issue Dec 7, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@neilstevenson
Copy link

neilstevenson commented Dec 7, 2018

Java client is doing hazelcast.shutdown()

On 3.11 this appears server side as:

2018-12-07 10:11:29.999  INFO 15952 --- [.IO.thread-in-1] com.hazelcast.nio.tcp.TcpIpConnection    : [127.0.0.1]:5701 [xxx] [3.11] Connection[id=1, /127.0.0.1:5701->localhost/127.0.0.1:51830, endpoint=[127.0.0.1]:51830, alive=false, type=JAVA_CLIENT] closed. Reason: Connection closed by the other side

java.io.EOFException: Remote socket closed!
	at com.hazelcast.internal.networking.nio.NioInboundPipeline.process(NioInboundPipeline.java:116) ~[hazelcast-3.11.jar!/:3.11]
	at com.hazelcast.internal.networking.nio.NioThread.processSelectionKey(NioThread.java:368) [hazelcast-3.11.jar!/:3.11]
	at com.hazelcast.internal.networking.nio.NioThread.processSelectionKeys(NioThread.java:353) [hazelcast-3.11.jar!/:3.11]
	at com.hazelcast.internal.networking.nio.NioThread.selectLoop(NioThread.java:279) [hazelcast-3.11.jar!/:3.11]
	at com.hazelcast.internal.networking.nio.NioThread.run(NioThread.java:234) [hazelcast-3.11.jar!/:3.11]

On 3.10.6,

2018-12-07 10:28:08.177  INFO 17811 --- [.IO.thread-in-0] com.hazelcast.nio.tcp.TcpIpConnection    : [127.0.0.1]:5701 [xxx] [3.10.6] Connection[id=1, /127.0.0.1:5701->localhost/127.0.0.1:57724, endpoint=[127.0.0.1]:57724, alive=false, type=JAVA_CLIENT] closed. Reason: Connection closed by the other side

The 3.11 behaviour is confusing, there's no error if the client has run shutdown() so an exception should not appear server side.

@sancar sancar added this to the 3.11.2 milestone Dec 7, 2018

@sancar sancar self-assigned this Dec 20, 2018

sancar added a commit to sancar/hazelcast that referenced this issue Dec 20, 2018

Removes EOFException stacktrace from log when connection closed
This regression introduced in
hazelcast#13743

If exception is EOFException or cancelledKeyException we were not
logging the stack-trace, unless logging is FINEST.

I restored the behaviour by keeping the intended fix(do not create the message
if not necessary).

fixes hazelcast#14244

sancar added a commit to sancar/hazelcast that referenced this issue Dec 20, 2018

Removes EOFException stacktrace from log when connection closed
This regression introduced in
hazelcast#13743

If exception is EOFException or cancelledKeyException we were not
logging the stack-trace, unless logging is FINEST.

I restored the behaviour by keeping the intended fix(do not create the message
if not necessary).

fixes hazelcast#14244

(cherry picked from commit c916979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.