Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading from backup does not update access data #7341

Open
GhostInAMachine opened this issue Jan 16, 2016 · 4 comments
Open

Reading from backup does not update access data #7341

GhostInAMachine opened this issue Jan 16, 2016 · 4 comments
Labels
Module: IMap Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Milestone

Comments

@GhostInAMachine
Copy link

When MapConfig option "readBackupData" is set to true then "get" operations do not trigger the update of access timestamps and hit count. This way the entries might get evicted even though they are frequently used.

Cause of this issue is in com.hazelcast.map.impl.DefaultRecordStore#readBackupData method.

@gurbuzali
Copy link
Contributor

Let's keep in mind that even if we update access-time/hit-count on DefaultRecordStore.readBackupData it will be on backup partition, owner partition will not be affected. Therefore the owner will evict the entry but the backup will retain.

@gurbuzali
Copy link
Contributor

Another point: We do not update localMapStats.getCount too (which are kept locally and updated in invokeOperation method of proxy ).

@tombujok
Copy link
Contributor

@gurbuzali @jerrinot @ahmetmircik The problem here is that when readBackupData == true when you do a get for a key that's on a partition with a replicaIndex == 0 on this node, the partitionThread will be bypassed and the stats will not be updated. That's a bug IMHO. This fix submitted (but not merged) by @jerrinot was correct: #8012 Any objections to merge it?

@tombujok
Copy link
Contributor

tombujok commented Jul 1, 2016

I'm moving it to 3.8 since we need the caller runs feature to implement it.
It's unsolvable in 3.6 or 3.7 without performance regression.
Some more comments here: #8489

@tombujok tombujok modified the milestones: 3.10, 3.9 Jul 10, 2017
@jerrinot jerrinot modified the milestones: 3.10, 3.11 Dec 7, 2017
@jerrinot jerrinot modified the milestones: 3.11, 3.12 Aug 26, 2018
@mmedenjak mmedenjak added the Source: Community PR or issue was opened by a community user label Aug 29, 2018
@dbrimley dbrimley modified the milestones: 3.12, 3.13 Nov 8, 2018
@mmedenjak mmedenjak modified the milestones: 3.13, 4.0 Apr 17, 2019
@mmedenjak mmedenjak modified the milestones: 4.0, 4.1 Oct 29, 2019
@Holmistr Holmistr modified the milestones: 4.1, Backlog Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: IMap Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Projects
None yet
9 participants