Fixes index creation in wrong map-container problem. #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run-lab-run |
1 similar comment
|
run-lab-run |
|
|
run-lab-run |
|
@ahmetmircik These client test failures will be fixed by #7836 |
ahmetmircik
force-pushed
the
fix/3.6.3/mapContainerRefs
branch
6 times, most recently
from
1463dec
to
21fe4ea
Compare
| @@ -284,6 +286,10 @@ public boolean isInvalidationEnabled() { | |||
| public InterceptorRegistry getInterceptorRegistry() { | |||
| return interceptorRegistry; | |||
| } | |||
|
|
|||
| public boolean canBeRemoved() { | |||
There was a problem hiding this comment.
a very small thing: something like markForRemoval() could be better. as a developer I do not expect a method starting with can- to have a side-effect.
There was a problem hiding this comment.
Thanks, completely removed that method, relying on mapContainers#remove(mapName, mapContainer) should be sufficient.
ahmetmircik
changed the title
…destroy and creation of imap, there is a possibility that there can be more than one map-container referenced by record-stores at the same time. Due to that indexes can be created in an unexpected map-container and this can lead to return less than expected number of results after querying imap
ahmetmircik
force-pushed
the
fix/3.6.3/mapContainerRefs
branch
from
21fe4ea
to
5579cb5
Compare
ahmetmircik
changed the title
| final PartitionContainer[] containers = partitionContainers; | ||
| final Semaphore semaphore = new Semaphore(0); | ||
| public void destroyMap(String mapName) { | ||
| MapContainer mapContainer = mapContainers.get(mapName); |
There was a problem hiding this comment.
which threads can call this method?
edit: I'll answer this myself. both partition threads & user thread can call this.
There was a problem hiding this comment.
user + generic operation
|
run-lab-run |
|
verify |
|
👍 |
1 similar comment
|
👍 |
This was referenced Mar 30, 2016
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
Upon subsequent destroy and creation of imap, there is a possibility that there can be more than one map-container referenced by different record-stores at the same time. Due to that, indexes can be created in an unexpected map-container and this can lead to return less than expected number of results when we query imap.
Fix:
Moved the removal of mapContainer to partition-thread, by making this, i want to be sure that after map#destroy, there is always a new mapContainer instance referenced from a newly created recordstore and that mapContainer instance is different from the removed one.
Test:
Testing this defect is so hard. I was able to reproduce it with adding some sleeps. But still trying to find a simple test also.