Do not retry TargetNotMemberException when invocation made on target #10404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run-lab-run |
1 similar comment
|
run-lab-run |
sancar
force-pushed
the
fix/targetNotMember/maint3.x
branch
from
10448bf
to
6f737a0
Compare
|
run-lab-run |
sancar
force-pushed
the
fix/targetNotMember/maint3.x
branch
from
6f737a0
to
f1d4bcc
Compare
|
Test PASSed. |
sancar
force-pushed
the
fix/targetNotMember/maint3.x
branch
from
f1d4bcc
to
cd5902e
Compare
sancar
force-pushed
the
fix/targetNotMember/maint3.x
branch
2 times, most recently
from
3b39c3b
to
89de4c1
Compare
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
sancar
force-pushed
the
fix/targetNotMember/maint3.x
branch
from
89de4c1
to
3c7541b
Compare
Invocation made `ProxyManager.initialize(ClientProxy)` was on connection to be able to prevent it from retrying. It was a workaround that does not comply with ClientInvocation API hence failed today. In this pr, I made the proxy creation invocation on address as intended. And I changed invocation exception handling so that it will not be retried when given address not a member anymore. Retrying does not make sense in this case. ClientLockWithTerminationTest.testLockOnClient_withNodeCrash was failing because it was retrying creating proxy on closed member until clientInvocationTimeout(120 seconds) hit and then throws OperationTimeoutException. This pr hazelcast#10370 made issue apparent. It was waiting for 120 seconds unncessarily, then throwing a retryableException(instead OperationTimeoutException). Because of retyable exception there issue was hidden. because fix needs changes there. fixes hazelcast#3422
|
Test PASSed. |
This was referenced Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocation made
ProxyManager.initialize(ClientProxy)was on connectionto be able to prevent it from retrying. It was a workaround that does not
comply with ClientInvocation API hence failed today.
In this pr, I made the proxy creation invocation on address as intended.
And I changed invocation exception handling so that it will not be retried
when given address not a member anymore. Retrying does not make sense in
this case.
ClientLockWithTerminationTest.testLockOnClient_withNodeCrash was failing
because it was retrying creating proxy on closed member until
clientInvocationTimeout(120 seconds) hit and then throws OperationTimeoutException.
This pr #10370 made issue apparent.
It was waiting for 120 seconds unncessarily, then throwing a
retryableException(instead OperationTimeoutException). Because of retyable
exception there issue was hidden.
because fix needs changes there.
fixes #3422