Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retry TargetNotMemberException when invocation made on target #10404

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Do not retry TargetNotMemberException when invocation made on target #10404

merged 1 commit into from
Apr 28, 2017

Commits on Apr 26, 2017

  1. Do not retry TargetNotMemberException when invocation made on target 

    Invocation made `ProxyManager.initialize(ClientProxy)` was on connection
to be able to prevent it from retrying. It was a workaround that does not
comply with ClientInvocation API hence failed today.

In this pr, I made the proxy creation invocation on address as intended.
And I changed invocation exception handling so that it will not be retried
when given address not a member anymore. Retrying does not make sense in
this case.

ClientLockWithTerminationTest.testLockOnClient_withNodeCrash was failing
because it was retrying creating proxy on closed member until
clientInvocationTimeout(120 seconds) hit and then throws OperationTimeoutException.

This pr hazelcast#10370 made issue apparent.
It was waiting for 120 seconds unncessarily, then throwing a
retryableException(instead OperationTimeoutException). Because of retyable
exception there issue was hidden.

because fix needs changes there.

fixes hazelcast#3422
    sancar committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    3c7541b View commit details
    Browse the repository at this point in the history