-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporting eclipsesource package in MANIFEST.MF #11318
Conversation
…test jar creation with correct MANIFEST.MF
run-lab-run |
verify |
This PR makes sure that following plugins run in package phase |
Test FAILed. |
run-lab-run |
1 similar comment
run-lab-run |
run-lab-run |
@noctarius or @jerrinot Can you guys have a look at this when you have time? |
please see #10994 |
fixes #10994
The problem in #10994 is that BundlePlugin generates MANIFEST.MF export/import packages before maven-shade-plugin relocates eclipsesource classes. That makes
com.hazelcast.com.eclipsesource.json
not visible to OSGI becauseExport-Package:
in MANIFEST.MF is already generated.Apparently,
hazelcast-aws
is using this package for JSON Parsing and fails in OSGI environment.There are two solutions to that
com.hazelcast.com.eclipsesource.json
dependency onhazelcast-aws
and use directly any other JSON ParserI have tried to implement 2nd solution but It fails in the last part of creating jar file. I just commented maven-jar-plugin and seems the rest works fine.
@Donnerbart @hasancelik any idea?
You can simply run
mvn clean package -DskipTests
in this PR and seecom.hazelcast.com.eclipsesource.json
added as Export package.