Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ListenerRegistrationHelper #11914

Closed

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Dec 4, 2017

Fix for @vbekiaris comment [here] (#11680 (comment))

  • ListenerRegistrationHelper is removed
  • Some renamings are done
@ahmetmircik ahmetmircik changed the title [DONT MERGE] Removed ListenerRegistrationHelper Removed ListenerRegistrationHelper Dec 5, 2017
@ahmetmircik ahmetmircik requested a review from vbekiaris Dec 5, 2017
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.10/removeNameGenerator branch from 07a8404 to 86ca0f8 Dec 5, 2017
Copy link
Contributor

vbekiaris left a comment

I think that since this PR is altering the naming scheme for listener registrations we may have trouble with query caches on a mixed 3.9/3.10 EE cluster during an upgrade.

@@ -119,17 +115,15 @@ public String addListener(String mapName, String cacheId, MapListener listener,

@Override
public boolean removeListener(String mapName, String cacheId, String listenerId) {
String listenerName = generateListenerName(mapName, cacheId);
return eventService.deregisterListener(SERVICE_NAME, listenerName, listenerId);
return eventService.deregisterListener(SERVICE_NAME, cacheId, listenerId);

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Dec 5, 2017

Contributor

Unrelated to this PR: is it OK that removeAllListeners is guarded with a mutex from lifecycleMutexFactory but removeListener is not?

@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented Dec 5, 2017

I think that since this PR is altering the naming scheme for listener registrations we may have trouble with query caches on a mixed 3.9/3.10 EE cluster during an upgrade.

@vbekiaris that's true, thanks. I set milestone to 4.0 and closing this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.