Removed ListenerRegistrationHelper #11914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
changed the title
ahmetmircik
force-pushed
the
fix/3.10/removeNameGenerator
branch
from
07a8404
to
86ca0f8
Compare
vbekiaris
reviewed
Dec 5, 2017
| @@ -119,17 +115,15 @@ public String addListener(String mapName, String cacheId, MapListener listener, | |||
|
|
|||
| @Override | |||
| public boolean removeListener(String mapName, String cacheId, String listenerId) { | |||
| String listenerName = generateListenerName(mapName, cacheId); | |||
| return eventService.deregisterListener(SERVICE_NAME, listenerName, listenerId); | |||
| return eventService.deregisterListener(SERVICE_NAME, cacheId, listenerId); | |||
There was a problem hiding this comment.
Unrelated to this PR: is it OK that removeAllListeners is guarded with a mutex from lifecycleMutexFactory but removeListener is not?
@vbekiaris that's true, thanks. I set milestone to 4.0 and closing this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for @vbekiaris comment [here] (#11680 (comment))