Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing backward compatibility issue for PER_NODE capacity calculation algorithm #12195

Merged
merged 4 commits into from Apr 10, 2018
Merged

Fixing backward compatibility issue for PER_NODE capacity calculation algorithm #12195

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97127c3
Fixed backward compatibility issue for PER_NODE capacity calculation …
Jan 25, 2018
6fe7eb8
Fixed code style to follow java checkstyle convention
Jan 30, 2018
7f0b5a1
Merge branch 'master' into per_node_cap_compatibility
Apr 5, 2018
5db8dba
fixed merging issues
Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 12 additions & 8 deletions hazelcast/src/main/java/com/hazelcast/map/impl/eviction/EvictionChecker.java
View file
Open in desktop
Expand Up @@ -53,6 +53,7 @@
public class EvictionChecker {

protected static final double ONE_HUNDRED_PERCENT = 100D;
private static final int MIN_SANE_PER_PARTITION_SIZE = 2;

protected final ILogger logger;
protected final MapServiceContext mapServiceContext;
Expand Down Expand Up @@ -123,14 +124,17 @@ public double translatePerNodeSizeToRecordStoreSize(RecordStore recordStore) {
int memberCount = nodeEngine.getClusterService().getSize(DATA_MEMBER_SELECTOR);
int partitionCount = nodeEngine.getPartitionService().getPartitionCount();

final double perNodeMaxRecordStoreSize = (1D * configuredMaxSize * memberCount / partitionCount);
if (perNodeMaxRecordStoreSize < 1
&& misconfiguredPerNodeMaxSizeWarningLogged.compareAndSet(false, true)) {
int minMaxSize = (int) Math.ceil((1D * partitionCount / memberCount));
String msg = "The max size configuration for map '%s' does not allow "
+ " any data in the map. Given the current cluster size of %d "
+ "members with %d partitions, max size should be at least %d.";
logger.warning(format(msg, mapConfig.getName(), memberCount, partitionCount, minMaxSize));
double perNodeMaxRecordStoreSize = (1D * configuredMaxSize * memberCount / partitionCount);
if (perNodeMaxRecordStoreSize < 1) {
perNodeMaxRecordStoreSize = MIN_SANE_PER_PARTITION_SIZE;
if (misconfiguredPerNodeMaxSizeWarningLogged.compareAndSet(false, true)) {
int minMaxSize = (int) Math.ceil((1D * partitionCount / memberCount));
int newSize = MIN_SANE_PER_PARTITION_SIZE * partitionCount / memberCount;
logger.warning(format("The max size configuration for map \"%s\" does not allow any data in the map. "
+ "Given the current cluster size of %d members with %d partitions, max size should be at "
+ "least %d. Map size is forced set to %d for backward compatibility", mapConfig.getName(),
memberCount, partitionCount, minMaxSize, newSize));
}
}
return perNodeMaxRecordStoreSize;
}
Expand Down