Fixing backward compatibility issue for PER_NODE capacity calculation algorithm

[Mak-Sym]

Followup on discussion in this issue: #11646. This simple fix adds backward compatibility to data eviction algorithm for cache sizes, smaller than number of partitions. This can be extremely useful especially after introducing dynamic map configuration feature.

[mmedenjak]

@Mak-Sym thanks for your contribution, before we can review & merge can you follow the instructions to sign and send the Hazelcast Contributor Agreement?

[Mak-Sym]

@mmedenjak I already did it.

[mmedenjak]

Thanks, can you tell me when you sent it? I will try and find out why it got stuck.

[Mak-Sym]

Received: by 10.103.127.15 with HTTP; Wed, 3 Jan 2018 17:20:01 -0800 (PST)
Date: Thu, 4 Jan 2018 12:20:01 +1100
Delivered-To: maksym.fedoryshyn@gmail.com
Message-ID: <CAHD8j7ZM7gKKT8-2fFat1-2AYZUdEJk42KQiOYjJJ4OTzTSEMQ@mail.gmail.com>
Subject: Hazelcast Contributor Agreement
From: Maksym Fedoryshyn <maksym.fedoryshyn@gmail.com>
To: jaromir@hazelcast.com```

[jerrinot]

hi,

I can confirm I received the agreement. I apologize for the delay.
Happy Hazelcasting!

[Mak-Sym]

Thank you!

…

On 25 Jan 2018 10:03 p.m., "Jaromir Hamala" ***@***.***> wrote: hi, I can confirm I received the agreement. I apologize for the delay. Happy Hazelcasting! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxtHPu1fdFRqJBtNhGHVlXwGipvvrWDks5tOF9_gaJpZM4RsQ6f> .

[rjatkins]

Should compare against MIN_SANE_PER_PARTITION_SIZE here, rather than just 1, so that we never allow fewer records per node than the minimum.

[Donnerbart]

This line will also fail with CheckStyle (we require a space here if ().

Please use CheckStyle on your local machine: mvn clean verify -Pcheckstyle -DskipTests

[Mak-Sym]

@rjatkins I left ability to set up cache size smaller than MIN_SANE_PER_PARTITION_SIZE just in case clients want to do that for whatever reason. I tried to fix the case, when cache size doesn't make sense (in other words, when cache size is definitely wrong). At the same time, partition size of 1 may make sense under some conditions. But I can also create useRecomendedMinSettings flag, which will force set partition size to MIN_SANE_PER_PARTITION_SIZE (with another warn message probably). What do you think?

@Donnerbart thx for the feedback - code formatting is fixed now.

[pveentjer]

@rjatkins can you rebase?

[ahmetmircik]

created a doc update issue for this PR: hazelcast/hazelcast-reference-manual#507

[ahmetmircik]

LGTM

[mmedenjak]

5 new commits :( ah well...