Set min translated per partition size to 1 instead of 2 #12824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmedenjak
approved these changes
Apr 11, 2018
| @@ -53,7 +53,7 @@ | |||
| public class EvictionChecker { | |||
|
|
|||
| protected static final double ONE_HUNDRED_PERCENT = 100D; | |||
| private static final int MIN_SANE_PER_PARTITION_SIZE = 2; | |||
| private static final int MIN_TRANSLATED_PARTITION_SIZE = 1; | |||
There was a problem hiding this comment.
Minor: can it be just MIN_PARTITION_SIZE? I didn't like the "sane" attribute as it implicates that setting it too low is "insane" and I'm not sure what "translated" is referring to.
ahmetmircik
force-pushed
the
fix/3.10/perNodeMinSize
branch
from
0d233c0
to
74321d0
Compare
vbekiaris
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was set to 2 in this PR: #12195
But 1 seems ok to fix the original issue: #11646