Introduced system property to provide backward #13501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
force-pushed
the
fix/3.11/entryLoadedCompatibility
branch
from
1a3f5d5
to
55b6b3e
Compare
pveentjer
reviewed
Jul 29, 2018
| @@ -72,6 +73,9 @@ | |||
| @SuppressWarnings("WeakerAccess") | |||
| public class MapContainer { | |||
|
|
|||
| public static final HazelcastProperty LOAD_ALL_PUBLISHES_ADD_EVENT | |||
There was a problem hiding this comment.
When should this property be enabled? How does an end user know this property needs to be set?
There was a problem hiding this comment.
Intention is to provide a soft pass. Because firing LOADED events upon loadAll call is not a backward compatible change. This system property can be removed in 4.0. Doc update is needed to inform user.
mmedenjak
reviewed
Aug 6, 2018
| @@ -140,11 +146,16 @@ public MapContainer(final String name, final Config config, final MapServiceCont | |||
| } else { | |||
| this.globalIndexes = null; | |||
| } | |||
| this.addEventPublishingEnabled = nodeEngine.getProperties().getBoolean(LOAD_ALL_PUBLISHES_ADD_EVENT); | |||
There was a problem hiding this comment.
Can we switch to nodeEngine.getProperties().getBoolean(LOAD_ALL_PUBLISHES_ADD_EVENT) and have it in group properties?
| @@ -72,6 +73,9 @@ | |||
| @SuppressWarnings("WeakerAccess") | |||
| public class MapContainer { | |||
|
|
|||
| public static final HazelcastProperty LOAD_ALL_PUBLISHES_ADD_EVENT | |||
There was a problem hiding this comment.
Can you add some javadoc for the property?
ahmetmircik
force-pushed
the
fix/3.11/entryLoadedCompatibility
branch
3 times, most recently
from
d353b2e
to
46431c1
Compare
mmedenjak
approved these changes
Aug 7, 2018
taburet
approved these changes
Aug 9, 2018
ahmetmircik
force-pushed
the
fix/3.11/entryLoadedCompatibility
branch
2 times, most recently
from
fab543e
to
f0d6cff
Compare
compatible event firing behavior for map#loadAll. When compatibility mode is on loadAll will fire ADD events, when off, it will fire LOADED event. By default LOADED events will be fired.
ahmetmircik
force-pushed
the
fix/3.11/entryLoadedCompatibility
branch
from
f0d6cff
to
5f5dec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatible event firing behavior for map#loadAll.
When compatibility mode is on loadAll will fire ADD events,
when off, it will fire LOADED event. By default LOADED events
will be fired.