Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientReauthOperation should be retryable #13790

Conversation

@sancar
Copy link
Member

@sancar sancar commented Sep 18, 2018

ClientReauthOperation is used with invokeOnStableClusterSerial
This requires for the operation to be safely retyable.

Before ClientReauthOperation was always throwing exception because
it was expecting to the new correlation id is always greater.

We are allowing it to be equal or greater than to last set
correlation id to make the operation safely retryable.

fixes https://github.com/hazelcast/hazelcast/issues/13758

(cherry picked from commit 6e2e1dc)

@sancar sancar added this to the 3.10.6 milestone Sep 18, 2018
@sancar sancar self-assigned this Sep 18, 2018
@sancar sancar force-pushed the sancar:fix/trySetLastAuthenticationCorrelationId/maint3.x branch from 6fafe52 to 6a02f4c Sep 18, 2018
ClientReauthOperation is used with `invokeOnStableClusterSerial`
This requires for the operation should be safely retyable.

Before ClientReauthOperation was always throwing exception because
it was expecting to the new correlation id is always greater.

We are allowing it to be equal or greater than to last set
correlation id to make the operation safely retryable.

fixes https://github.com/hazelcast/hazelcast/issues/13758

(cherry picked from commit 6e2e1dc)
@sancar sancar force-pushed the sancar:fix/trySetLastAuthenticationCorrelationId/maint3.x branch from 6a02f4c to a133fc9 Sep 18, 2018
@sancar sancar merged commit 54addac into hazelcast:maintenance-3.x Sep 19, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/trySetLastAuthenticationCorrelationId/maint3.x branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.