Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing all connections when heartbeat timeout #14096

Conversation

sancar
Copy link
Contributor

@sancar sancar commented Nov 12, 2018

This was actually addressed in following pr.
Members and clients disconnect the connection as soon as
heartbeat timeout is detected.

#12765

This pr fixes member side heartbeat monitor. It was not closing
the connections if the connection is not an owner connection.

fixes #14094

(cherry picked from commit 17e598c)

@sancar sancar added this to the 3.11.1 milestone Nov 12, 2018
@sancar sancar self-assigned this Nov 12, 2018
sancar added 3 commits November 15, 2018 11:40
This was actually addressed in following pr.
Members and clients disconnect the connection as soon as
heartbeat timeout is detected.

hazelcast#12765

This pr fixes member side heartbeat monitor. It was not closing
the connections if the connection is not an owner connection.

fixes hazelcast#14094

(cherry picked from commit 17e598c)
@sancar sancar force-pushed the fix/closeNonOwnersWhenHeartbeatTimeout/maint3.x branch from a4acb79 to 2b417a9 Compare November 15, 2018 08:40
@sancar sancar merged commit d908679 into hazelcast:maintenance-3.x Nov 15, 2018
@sancar sancar deleted the fix/closeNonOwnersWhenHeartbeatTimeout/maint3.x branch November 15, 2018 12:31
@sancar sancar restored the fix/closeNonOwnersWhenHeartbeatTimeout/maint3.x branch November 20, 2018 07:00
@sancar sancar deleted the fix/closeNonOwnersWhenHeartbeatTimeout/maint3.x branch November 20, 2018 07:00
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants