Fixing initial membership event when client start async #14391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were firing two events mistakenly when a client starts async. The first event was empty. This pr adds a check for the first event. If the member list is empty, it means that the initial membership event did not arrive yet. We don't need to fire an event. The actual event will come later and delivered to user-listener. fixes hazelcast#14364
sancar
force-pushed
the
fix/initialMemberListOnClientAsyncStart/master
branch
from
4e9c367
to
83ebe25
Compare
eminn
approved these changes
Jan 18, 2019
ihsandemir
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were firing two events mistakenly when a client starts async.
The first event was empty. This pr adds a check for the first event.
If the member list is empty, it means that the initial membership
event did not arrive yet. We don't need to fire an event.
The actual event will come later and delivered to user-listener.
fixes #14364