Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes IMap#replace not loading from MapLoader #14797

Merged
merged 1 commit into from Apr 5, 2019
Merged

Fixes IMap#replace not loading from MapLoader #14797

merged 1 commit into from Apr 5, 2019

Conversation

mustafaiman
Copy link
Contributor

replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes #11300

@mustafaiman mustafaiman added this to the 3.13 milestone Apr 3, 2019
@vbekiaris vbekiaris self-requested a review April 5, 2019 13:34
vbekiaris
vbekiaris approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should add the load interaction explicitly in IMap javadoc (just like we already mention the write part). Once that's done I'm fine to merge.

@mustafaiman
Fixes IMap#replace not loading from MapLoader
57e0a43 
replace operation just overlooked MapLoader when given key is not present in-memory. Instead, it should try to load from MapLoader first.

fixes hazelcast#11300
@mustafaiman
Copy link
Contributor Author

@vbekiaris I added documentation to two replace methods in IMap. Can you check if those are good?

vbekiaris
vbekiaris approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mustafaiman

@mustafaiman mustafaiman merged commit 166c5fc into hazelcast:master Apr 5, 2019
@mustafaiman mustafaiman deleted the fix/map-replace-maploader branch April 5, 2019 17:39
@mmedenjak mmedenjak modified the milestones: 3.13, 4.0 Apr 17, 2019
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbekiaris vbekiaris vbekiaris approved these changes

@ahmetmircik ahmetmircik ahmetmircik approved these changes

Assignees
No one assigned
Labels
Module: IMap Source: Internal PR or issue was opened by an employee Team: Core Type: Enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

DefaultRecordStore#replace methods should load from MapLoader when key not found in storage
4 participants
@mustafaiman @vbekiaris @ahmetmircik @mmedenjak