Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wakeup bug in NioOutboundPipeline #14831

Conversation

@pveentjer
Copy link
Member

pveentjer commented Apr 3, 2019

Fixes #14830.

@pveentjer pveentjer force-pushed the pveentjer:v3.12/fix/wakeup-bug-NioOutboundPipeline branch from 587c1d9 to f3acbac Apr 3, 2019
@pveentjer pveentjer added this to the 3.12 milestone Apr 3, 2019
Copy link
Contributor

kwart left a comment

Just a minor comment WRT backward compatible probe values. Otherwise LGTM.

@mmedenjak mmedenjak removed this from the 3.12 milestone Apr 3, 2019
@pveentjer pveentjer force-pushed the pveentjer:v3.12/fix/wakeup-bug-NioOutboundPipeline branch from f3acbac to 4d8d274 Apr 4, 2019
@pveentjer

This comment has been minimized.

Copy link
Member Author

pveentjer commented Apr 4, 2019

I have addressed your comment @kwart . Can you have another look?

@kwart
kwart approved these changes Apr 4, 2019
private long isScheduled() {
return scheduled.get() ? 1 : 0;
private long scheduled() {
return scheduled.get().ordinal();

This comment has been minimized.

Copy link
@mmedenjak

mmedenjak Apr 4, 2019

Contributor

This is rather unconventional. Any reason we can't use something like return scheduled.get() == State.SCHEDULED ? 1 : 0?
I'm thinking if someone changes the order. The value of this method returns as well.

@mmedenjak mmedenjak merged commit 05b0eab into hazelcast:master Apr 4, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@pveentjer pveentjer deleted the pveentjer:v3.12/fix/wakeup-bug-NioOutboundPipeline branch Apr 4, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.