[BACKPORT] Improve the Raft snapshotting optimization #15068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is at least one follower with unknown match index, its log can be close to the leader's log so we are keeping the old log entries. Otherwise, we will keep the log entries until the minimum match index that is bigger than (commitIndex - maxNumberOfLogsToKeepAfterSnapshot). If there is no such follower (all of the minority followers are far behind), then there is no need to keep the old log entries.
mdogan
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is at least one follower with unknown match index, its log can
be close to the leader's log so we are keeping the old log entries.
Otherwise, we will keep the log entries until the minimum match index
that is bigger than (commitIndex - maxNumberOfLogsToKeepAfterSnapshot).
If there is no such follower (all of the minority followers are far
behind), then there is no need to keep the old log entries.
Backport of #15062