Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Improve the Raft snapshotting optimization #15068

Conversation

Projects
None yet
2 participants
@metanet
Copy link
Contributor

commented May 21, 2019

If there is at least one follower with unknown match index, its log can
be close to the leader's log so we are keeping the old log entries.
Otherwise, we will keep the log entries until the minimum match index
that is bigger than (commitIndex - maxNumberOfLogsToKeepAfterSnapshot).
If there is no such follower (all of the minority followers are far
behind), then there is no need to keep the old log entries.

Backport of #15062

Improve the Raft snapshotting optimization
If there is at least one follower with unknown match index, its log can
be close to the leader's log so we are keeping the old log entries.
Otherwise, we will keep the log entries until the minimum match index
that is bigger than (commitIndex - maxNumberOfLogsToKeepAfterSnapshot).
If there is no such follower (all of the minority followers are far
behind), then there is no need to keep the old log entries.

@metanet metanet added this to the 3.12.1 milestone May 21, 2019

@metanet metanet requested a review from mdogan May 21, 2019

@mdogan

mdogan approved these changes May 22, 2019

@metanet metanet merged commit f089d9c into hazelcast:maintenance-3.x May 23, 2019

1 check passed

default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.