Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isMaster() guards in migration system #15617

Merged
merged 1 commit into from
Sep 27, 2019

Commits on Sep 26, 2019

  1. Fix isMaster() guards in migration system

    `node.isMaster()` was being used in migration mechanism
    to detect whether or not a node is master. Depending on this
    check, a process executes or rejects to execute.
    
    But while a migration method is executing under partition service
    lock, the node may become master (when former master leaves the cluster).
    This may cause inconsistenct behaviours during execution of the specific method.
    
    For example, master node increments partition version when a replica ownership
    changes. If a node becomes master while appyling partition table updates,
    the race mentioned above can cause multiple increments of partition version.
    mdogan committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    fa96163 View commit details
    Browse the repository at this point in the history