Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize local CP member before initializing metadata group #15684

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Initialize local CP member before initializing metadata group #15684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions hazelcast/src/main/java/com/hazelcast/cp/internal/MetadataRaftGroupManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,15 +1320,14 @@ private boolean commitMetadataRaftGroupInit(CPMemberInfo localCPMemberCandidate,
}
raftService.createRaftNode(metadataGroupId, metadataEndpoints, localCPMemberCandidate.toRaftEndpoint());
}

RaftOp op = new InitMetadataRaftGroupOp(localCPMemberCandidate, discoveredCPMembers, metadataGroupId.getSeed());
raftService.getInvocationManager().invoke(metadataGroupId, op).get();
// By default, we use the same member UUID for both AP and CP members.
// But it's not guaranteed to be same. For example;
// - During a split-brain merge, AP member UUID is renewed but CP member UUID remains the same.
// - While promoting a member to CP when Hot Restart is enabled, CP member doesn't use the AP member's UUID
// but instead generates a new UUID.
localCPMember.set(localCPMemberCandidate);
RaftOp op = new InitMetadataRaftGroupOp(localCPMemberCandidate, discoveredCPMembers, metadataGroupId.getSeed());
raftService.getInvocationManager().invoke(metadataGroupId, op).get();
metadataStore.persistLocalCPMember(localCPMemberCandidate);
} catch (Exception e) {
logger.severe("Could not initialize METADATA CP group with CP members: " + metadataMembers, e);
Expand Down