Move JsonSerializable to private API #16032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazember
approved these changes
Nov 15, 2019
emre-aydin
approved these changes
Nov 18, 2019
hazelcast/src/main/java/com/hazelcast/internal/monitor/impl/MemberStateImpl.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 18, 2019 10:35
JsonSerializable is supposed to be used only when exchanging statistics with management center. Previously, it was public API because some statistics classes such as LocalMapStats were exposed as public methods. Now we move JsonSerializable to private API. Because of this, we have to cast whenever we want to transform from/to JSON as most internal code exchanges stats interfaces such as LocalMapStats. The alternative is that the internal API exchanges concrete classes such as LocalMapStatsImpl but this is not possible since sometimes there are two different implementations for the same stats interface. Addresses hazelcast#15888 (comment)
mmedenjak
force-pushed
the
4.0-json-serializable
branch
from
1434b37
to
08d281d
Compare
petrpleshachkov
pushed a commit
to petrpleshachkov/hazelcast
that referenced
this pull request
Nov 22, 2019
Move JsonSerializable to private API JsonSerializable is supposed to be used only when exchanging statistics with management center. Previously, it was public API because some statistics classes such as LocalMapStats were exposed as public methods. Now we move JsonSerializable to private API. Because of this, we have to cast whenever we want to transform from/to JSON as most internal code exchanges stats interfaces such as LocalMapStats. The alternative is that the internal API exchanges concrete classes such as LocalMapStatsImpl but this is not possible since sometimes there are two different implementations for the same stats interface. Addresses hazelcast#15888 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSerializable is supposed to be used only when exchanging statistics
with management center. Previously, it was public API because some
statistics classes such as LocalMapStats were exposed as public methods.
Now we move JsonSerializable to private API. Because of this, we have to
cast whenever we want to transform from/to JSON as most internal code
exchanges stats interfaces such as LocalMapStats. The alternative is
that the internal API exchanges concrete classes such as
LocalMapStatsImpl but this is not possible since sometimes there are two
different implementations for the same stats interface.
Addresses #15888 (comment)
EE: https://github.com/hazelcast/hazelcast-enterprise/pull/3358