Change default fallback for unrecognised REST group text commands #16237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
added
Type: Enhancement
Team: Core
Source: Internal
tkountis
commented
Dec 11, 2019
| @@ -78,8 +78,8 @@ | |||
| public static final String URI_CP_SUBSYSTEM_BASE_URL = "/hazelcast/rest/cp-subsystem"; | |||
| public static final String URI_RESET_CP_SUBSYSTEM_URL = URI_CP_SUBSYSTEM_BASE_URL + "/reset"; | |||
| public static final String URI_CP_GROUPS_URL = URI_CP_SUBSYSTEM_BASE_URL + "/groups"; | |||
| public static final String URI_CP_SESSIONS_SUFFIX = "/sessions"; | |||
| public static final String URI_REMOVE_SUFFIX = "/remove"; | |||
| public static final String URI_CP_SESSIONS_SUFFIX = URI_CP_SUBSYSTEM_BASE_URL + "/sessions"; | |||
There was a problem hiding this comment.
@metanet was this intended or a mistake? If the former, please let me know so I can revert.
tkountis
force-pushed
the
fix/4.0/rest-groups-default-to-null
branch
from
34ca170
to
ce43bb7
Compare
|
You can also rebase as I see some URIs have been removed in the meantime. |
tkountis
force-pushed
the
fix/4.0/rest-groups-default-to-null
branch
from
ce43bb7
to
015953d
Compare
kwart
approved these changes
Dec 13, 2019
mmedenjak
approved these changes
Dec 13, 2019
tkountis
force-pushed
the
fix/4.0/rest-groups-default-to-null
branch
2 times, most recently
from
7337afa
to
b85ee4b
Compare
tkountis
force-pushed
the
fix/4.0/rest-groups-default-to-null
branch
from
b85ee4b
to
e9d29ab
Compare
mdogan
added a commit
to mdogan/hazelcast
that referenced
this pull request
Dec 18, 2019
CP subsystem was using `CLUSTER_WRITE_ group before but a new `CP` group is added by hazelcast#16237.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15957
Added a new REST group too for CP APIs, and fixed some of the CP URIs.
I was also tempted to throw handle the error differently for each protocol, but at this stage of filtering the incoming request, for unified networking, we don't know whether its HTTP or Memcache. Therefore we rely on the previous way of just closing the connection without responding.