Introduce mode for persistent-memory configuration #17696
Conversation
| @@ -433,7 +433,7 @@ | |||
| min-block-size="10" | |||
| page-size="20"> | |||
| <hz:size unit="GIGABYTES" value="256"/> | |||
| <hz:persistent-memory> | |||
| <hz:persistent-memory enabled="false" mode="MOUNTED"> | |||
There was a problem hiding this comment.
If enabled flag is set to false, why do we still have the directory element underneath?
There was a problem hiding this comment.
We need to test parsing regardless of the value of enabled. Probably it would be better to set it to true instead since false is the default.
There was a problem hiding this comment.
I kept false instead, this way we have cases both for enabled and disabled persistent memory config.
| throw new InvalidConfigurationException("Invalid 'mode' for 'persistent-memory': " + modeValue); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If enabledNode is false, shall we go through the directories?
There was a problem hiding this comment.
I think yes. We need to build a config object hierarchy matching the declarative config.
| @@ -28,11 +28,18 @@ | |||
| * Configuration class for persistent memory devices (e.g. Intel Optane). | |||
| */ | |||
| public class PersistentMemoryConfig { | |||
| private boolean enabled; | |||
There was a problem hiding this comment.
Javadoc would be useful.
Introduce config attribute for the operational mode of the persistent memory. Two modes supported: `MOUNTED (FS DAX)` and `SYSTEM_MEMORY (KMEM DAX)`. With this setting, the user can define to use PMEM in the KMEM DAX mode. Additionally, an `enabled` toggle is added to `persistent-memory`, which makes it explicit when persisten memory is used. For legacy reasons, if the `persistent-memory-directory` that was introduced in 4.0 is set, `enabled` is set to `true`, so the users already using persistent memory don't need to change their configs. Otherwise, the persistent memory should be explicitly enabled by setting `enabled` to `true`, since the default is `false`.
blazember
force-pushed
the
4.1/optane/kmem-dax-2
branch
from
9064d7a
to
1b877bc
Compare
hazelcast/src/main/java/com/hazelcast/internal/config/AbstractDomConfigProcessor.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @mmedenjak @petrpleshachkov @sancar 👍 |
Introduce config attribute for the operational mode of the persistent memory. Two modes supported:
MOUNTED (FS DAX)andSYSTEM_MEMORY (KMEM DAX). With this setting, the user can define to use PMEM in the KMEM DAX mode. Additionally, anenabledtoggle is added topersistent-memory, which makes it explicit when persisten memory is used. For legacy reasons, if thepersistent-memory-directorythat was introduced in 4.0 is set,enabledis set totrue, so the users already using persistent memory don't need to change their configs. Otherwise, the persistent memory should be explicitly enabled by settingenabledtotrue, since the default isfalse.EE PR: https://github.com/hazelcast/hazelcast-enterprise/pull/3814