Changed should to must in exception messages #17710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Can one of the admins verify this patch? |
|
|
|
It seems two unrelated commits leaked to this PR. Could you remove them from it? I usually use the following approach when rebasing: # update local copies of remote repositories
git fetch --all
# rebase to the latest version of the master branch (upstream points to the hazelcast/hazelcast repository in my case)
# during the interactive (-i) rebase you can remove the 2 unrelated commits
git rebase -i upstream/master
## if there is a conflict which needs manual resolution, I use the following:
# git mergetool
# git rebase --continue |
|
Hi @kwart , yes, not sure how that happened sorry. I'll try to fix it. |
ndeevy
force-pushed
the
ndeevy-replace-word-should
branch
from
4b3b326
to
d7c3569
Compare
|
Hi @kwart The PR just has my one original commit now. Thanks for your help. |
|
It's better now. I'm sorry to say it, but it has again a conflict in
|
ndeevy
force-pushed
the
ndeevy-replace-word-should
branch
from
d7c3569
to
2867088
Compare
ndeevy
force-pushed
the
ndeevy-replace-word-should
branch
from
2867088
to
b7d5448
Compare
|
Thanks @kwart :-] conflict should be gone now. |
sancar
approved these changes
Oct 19, 2020
|
Congratulations, @ndeevy, the PR is merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11723
Replaced the word 'should' with (in most cases) 'must' in exception messages. This is to improve user focus and to indicate obligation rather than advice.