Portable with OBJECT format on SQL when factory is missing #18891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
added
Type: Enhancement
Team: Client
Source: Internal
sancar
changed the title
srknzl
reviewed
Jun 15, 2021
hazelcast-sql/src/test/java/com/hazelcast/sql/PortableQueryTest.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/test/java/com/hazelcast/sql/PortableQueryTest.java
Outdated
Show resolved
Hide resolved
When the factory config is missing on the server but server is configured in memory format as Data, we can store Portable's as PortableGenericRecord and still query them without needing to convert them to Object/Data. This pr adds related test to old query. Also updates new query system to allow that usage and adds a related test.
sancar
force-pushed
the
fix/portableNewSql/master
branch
from
a495a88
to
f47d01c
Compare
srknzl
approved these changes
Jun 16, 2021
gierlachg
approved these changes
Jun 16, 2021
|
|
||
| SqlResult rows = client.getSql().execute("SELECT * FROM test WHERE i >= 45"); | ||
| AtomicInteger integer = new AtomicInteger(0); | ||
| rows.iterator().forEachRemaining(sqlRow -> integer.incrementAndGet()); |
There was a problem hiding this comment.
Can be simplified with Iterators.size().
|
|
||
| Iterator<SqlRow> iterator = rows.iterator(); | ||
| SqlRow row = iterator.next(); | ||
| assertFalse(iterator.hasNext()); |
There was a problem hiding this comment.
Can be simplified with Iteratros.getOnlyElement().
|
I would wait for @viliam-durina's review as well. |
viliam-durina
approved these changes
Jun 16, 2021
|
@gierlachg @viliam-durina Thanks for the reviews. I will not backport this to older maintenance branches since the feature was Beta, if that is ok ? |
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Errors: [ERROR] ClientExecutorSplitBrainProtectionReadTest.setUp:44->AbstractSplitBrainProtectionTest.initTestEnvironment:105->AbstractSplitBrainProtectionTest.initCluster:247 ? SplitBrainProtection [INFO] [ERROR] Tests run: 38557, Failures: 0, Errors: 1, Skipped: 1004 [INFO] |
|
run-lab-run |
Sure it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the factory config is missing on the server but
the map is configured with in-memory format Object, we can store
Portables as PortableGenericRecord and still query them
without needing to convert them to Object/Data.
This PR adds related test to old query engine.
Also updates new query system to allow that usage and adds
a related test.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release Noteslabel if changes should be mentioned in release notes orNot Release Notes contentif changes are not relevant for release notes@Nonnull/@Nullableannotations@sincetags in Javadoc