Deprecate STATISTICS properties #19219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes hazelcast#18579
sancar
added
Team: Client
Source: Internal
ihsandemir
reviewed
Jul 29, 2021
hazelcast/src/main/java/com/hazelcast/internal/metrics/impl/MetricsConfigHelper.java
Show resolved
Hide resolved
sancar
added
the
All Languages Should Check
This was referenced Jul 29, 2021
|
metricsConfig does not exist on Node.js client and statistics properties are used. Should I add metricsConfig, or is it fine to use statistics properties? |
ihsandemir
approved these changes
Jul 29, 2021
mdumandag
reviewed
Jul 30, 2021
hazelcast/src/main/java/com/hazelcast/client/properties/ClientProperty.java
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/client/properties/ClientProperty.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/config/BaseMetricsConfig.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/config/BaseMetricsConfig.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/internal/metrics/impl/MetricsConfigHelper.java
Outdated
Show resolved
Hide resolved
mdumandag
approved these changes
Jul 30, 2021
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Jul 30, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes hazelcast#18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Jul 30, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes hazelcast#18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Jul 30, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes hazelcast#18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
This was referenced Jul 30, 2021
sancar
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes #18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
sancar
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes #18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
sancar
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Deprecate STATISTICS properties
The following properties are not used anymore since 4.0
```
public static final HazelcastProperty STATISTICS_ENABLED = new HazelcastProperty("hazelcast.client.statistics.enabled",
false);
/**
* The period in seconds the statistics run.
*/
public static final HazelcastProperty STATISTICS_PERIOD_SECONDS = new HazelcastProperty(
"hazelcast.client.statistics.period.seconds", 3, SECONDS);
```
I traced it back to this pr. It seems that we are checking metricsConfig instead.
This pr:
1. puts @deprecated to the property documents on ClientProperties class.
2. If user sets statistics, make sure it will set metrics config as well. This is because there
were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
3. If both properties are set, ignore old STATISTICS properties.
4. Adds javadoc to ClientProperty and MetricsConfig to explain the effects of using these properties
fixes #18579
* fix javadoc styling and add test to verify new behaviour
(cherry picked from commit fde1a42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties are not used anymore since 4.0
I traced it back to this pr. It seems that we are checking metricsConfig instead.
#15963
This pr:
@Deprecatedto the property documents on ClientProperties class.were no warning or documentation about the removal. According to doc, these properties still used.
So we fix the behaviour.
fixes #18579
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release Noteslabel if changes should be mentioned in release notes orNot Release Notes contentif changes are not relevant for release notes@Nonnull/@Nullableannotations@sincetags in Javadoc