Enable instance tracking by default for NLC builds #19250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instance tracking should be on by default, but only for NLC builds. The field is set to true by the constructor but we need to introduce additional changes to prevent instance tracking of being disabled even though the user didn't add any configuration: - we need to remove instances tracking config from both XML and YAML default config files - we need to prevent setting the enabled field unless there is content found for the "enabled" field. Otherwise, even an empty instance tracking config could be parsed by YAML parser, and it would disable instance tracking - also, NLC builds don't have a default file name and it should be explicitly set. Non-NLC builds use the default file name. Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/4166
mmedenjak
added
Type: Enhancement
Team: Core
Source: Internal
blazember
reviewed
Aug 2, 2021
hazelcast/src/main/java/com/hazelcast/config/InstanceTrackingConfig.java
Outdated
Show resolved
Hide resolved
- made tests use small instances - addressed review comments
mmedenjak
requested review from
blazember and
emre-aydin
and removed request for
kwart
emre-aydin
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance tracking should be on by default, but only for NLC builds. The
field is set to true by the constructor but we need to introduce
additional changes to prevent instance tracking of being disabled even
though the user didn't add any configuration:
default config files
found for the "enabled" field. Otherwise, even an empty instance
tracking config could be parsed by YAML parser, and it would disable
instance tracking
explicitly set. Non-NLC builds use the default file name.
Fixes: https://github.com/hazelcast/hazelcast-enterprise/issues/4166
EE: https://github.com/hazelcast/hazelcast-enterprise/pull/4182