MC-1075 - fix ReliableTopic totalPublishes metric

[promanenko]

Previously ReliableTopic stats (published/received messages) were reported only when ReliableTopicProxy was used. No stats were reported If ClientReliableTopicProxy was used. Since ReliableTopic is always backed by a RingBuffer, we can report ReliableTopic stats from the RB operations if the RB name has a prefix "_hz_rb_"

Fixes #19555

Breaking changes (list specific methods/types/messages):

• none

[sancar]

Looks good. Are we going to backport this one to 4.x/5.0.x series ?

[promanenko]

Looks good. Are we going to backport this one to 4.x/5.0.x series ?

I'm not sure we need it for 4.X since it's a minor issue. For 5.0.x probably yes, we have it in scope of MC5.0.1 release.
@emre-aydin please confirm

[emre-aydin]

@promanenko agreed.

[rksharma1972]

I reported this issue and we have no plans to move to 5.0 for some time. Please consider fixing it in 4.2.2.

Thanks,
Rakesh

[rksharma1972]

Also as per Hazelcast docs ReliableTopic Name and RingBuffer Name should be same. But that's not the case either. Hazelcast docs should be updated to include that _hz_rb_ in RingBuffer name to get the correct stats.

Thanks,
Rakesh

[promanenko]

I reported this issue and we have no plans to move to 5.0 for some time. Please consider fixing it in 4.2.2.

OK, I will backport it to 4.x line too

Also as per Hazelcast docs ReliableTopic Name and RingBuffer Name should be same. But that's not the case either. >Hazelcast docs should be updated to include that hz_rb in RingBuffer name to get the correct stats.

The documentation is correct, the names of ReliableTopic and RingBuffer must be the same. _hz_rb_ is added under the hood to prevent users accidentally retrieving the ringbuffer.

[rksharma1972]

There is no way one can escape the need to setup RingBuffer when it comes to Reliable Topic. We need to provide the RingBuffer Configuration like backup copies, capacity and so on which will be used by corresponding Reliable Topic. But while configuration if we keep RingBuffer and Reliable Topic name same, It does not work because behind the scene different RingBuffer is created and used for the Reliable Topic. My configuration setting for RingBuffer is not used because of name is prefixed in background with "_hz_rb_". So I have changed my code to add "_hz_rb_" to the Ringbuffer name to fix the issue. It is working for us but it was hard to find in first place what's happening in the background. I posted the same question on community group but I did not get any hit on that when I initially faced this issue. Also we need to have a way to read all the messages published to Reliable Topic when Hazelcast client starts after the messages already published. Since we have attached RelableMessageListener to Reliable Topic and we passed RingBuffer Object to Listener so that during retrieveInitialSequence we have used headSequence of corresponding RingBuffer to initialize sequence. I am not sure why it is not been reported till now. Thanks, Rakesh