Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not execute cluster ops when querying node state #19829

Merged
merged 1 commit into from Oct 22, 2021
Merged

Do not execute cluster ops when querying node state #19829

merged 1 commit into from Oct 22, 2021

Conversation

vbekiaris
Copy link
Collaborator

Changes handling of health check rest endpoint
so that cluster operations are only used when
required by the queried endpoint.

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@vbekiaris
Do not execute cluster ops when querying node state
1e83a86 
Changes handling of health check rest endpoint
so that cluster operations are only used when
required by the queried endpoint.
@vbekiaris vbekiaris added this to the 5.1 milestone Oct 22, 2021
@vbekiaris vbekiaris requested a review from kwart October 22, 2021 06:51
@vbekiaris
Copy link
Collaborator Author

run-lab-run

kwart
kwart approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@hazelcast hazelcast deleted a comment from hz-devops-test Oct 22, 2021
@vbekiaris vbekiaris mentioned this pull request Oct 22, 2021
Merged
@ramizdundar ramizdundar self-requested a review October 22, 2021 12:10
@vbekiaris vbekiaris merged commit fbb75e1 into hazelcast:master Oct 22, 2021
vbekiaris added a commit to vbekiaris/hazelcast that referenced this pull request Nov 5, 2021
@vbekiaris
Do not execute cluster ops when querying node state (hazelcast#19829)
6c8cbf4 
Changes handling of health check rest endpoint
so that cluster operations are only used when
required by the queried endpoint.

(cherry picked from commit fbb75e1)
@vbekiaris vbekiaris mentioned this pull request Nov 5, 2021
Merged
vbekiaris added a commit to vbekiaris/hazelcast that referenced this pull request Nov 5, 2021
@vbekiaris
Do not execute cluster ops when querying node state (hazelcast#19829)
d64ef2b 
Changes handling of health check rest endpoint
so that cluster operations are only used when
required by the queried endpoint.

(cherry picked from commit fbb75e1)
@vbekiaris vbekiaris mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwart kwart kwart approved these changes

@ramizdundar ramizdundar ramizdundar approved these changes

Assignees
No one assigned
Labels
Module: REST Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbekiaris @kwart @ramizdundar