[HZ-757] Support sub-queries and VALUES() execution in JOIN arguments #20042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fly-Style
added
Type: Enhancement
Source: Internal
Fly-Style
changed the title
|
✅ Linked to Task HZ-757 · Support sub-queries execution in JOIN arguments [GH#19972] |
galibey
approved these changes
Dec 8, 2021
viliam-durina
approved these changes
Dec 10, 2021
| )) | ||
| .hasCauseInstanceOf(QueryException.class) | ||
| .hasMessageContaining("VALUES clause not supported on the right side of a (LEFT) JOIN or the left side of a RIGHT JOIN"); | ||
| assertRowsAnyOrder("SELECT * FROM " + leftName + " l JOIN (VALUES (1, 1)) AS r ON true", |
There was a problem hiding this comment.
Minor: it's better to use distinct values, not 1's everywhere. This way it can catch more issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset