Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance of SqlPage.getColumnValueForClient #20398

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

krzysztofslusarski
Copy link
Contributor

@krzysztofslusarski krzysztofslusarski commented Jan 17, 2022

Changing the List implementation from LinkedList to ArrayList. This part of code has an impact on com/hazelcast/sql/impl/client/SqlPage.getColumnValueForClient method. The SQL select(*) benchmark on the client machine profiling result (wall-clock mode):

image

The rigth part of the flame graph is:

image

The other parts are:

  • deserialization (that s optional)
  • waiting for a cluster to repond

After switching the implementation:

image

In terms of the benchmark it speeds up:

  • over 5% with deserializion on client's side
  • over 10% with no deserialization

@krzysztofslusarski krzysztofslusarski merged commit 38086c2 into master Jan 20, 2022
@krzysztofslusarski krzysztofslusarski deleted the sql-client-performance branch January 20, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants