Fix performance of SqlPage.getColumnValueForClient #20398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
List
implementation fromLinkedList
toArrayList
. This part of code has an impact oncom/hazelcast/sql/impl/client/SqlPage.getColumnValueForClient
method. The SQLselect(*)
benchmark on the client machine profiling result (wall-clock mode):The rigth part of the flame graph is:
The other parts are:
After switching the implementation:
In terms of the benchmark it speeds up: